Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vault conversion functions are susceptible to inflation attacks. #98

Open
eyqs opened this issue Nov 14, 2024 · 0 comments
Open

Vault conversion functions are susceptible to inflation attacks. #98

eyqs opened this issue Nov 14, 2024 · 0 comments

Comments

@eyqs
Copy link
Member

eyqs commented Nov 14, 2024

In convertToShares and convertToAssets in AggregateToken.sol, attackers can try depositing / withdrawing a very small amount and potentially drain the vault. We should implement some rounding similar to OpenZeppelin's ERC-4626 functions (like in pUSD.sol) to stop this from happening.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eyqs and others