Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally create review comments #14

Open
adangel opened this issue Dec 2, 2021 · 2 comments
Open

Optionally create review comments #14

adangel opened this issue Dec 2, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@adangel
Copy link
Member

adangel commented Dec 2, 2021

With #7 inline annotations are created, but they can't be commented or resolved. The PMD GitHub Action could add comments for each found violation when running on a pull request. This requires to only consider the modified files (#6).
See https://github.com/rody/pmd-review-github-action for the idea.

This should add a new input parameter for the action, which can switch on this feature. When review comments are created, no annotations should be created then.

See also #12 (comment)

@adangel adangel added enhancement New feature or request help wanted Extra attention is needed labels Dec 2, 2021
@adangel
Copy link
Member Author

adangel commented Aug 24, 2022

This is similar to what https://github.com/mitchspano/sfdx-scan-pull-request does: "... generates in-line comments with the findings"

@abbas-v1
Copy link

abbas-v1 commented Nov 2, 2022

Here's an example PR with comments
kemsakurai/mixcloud-java-api#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants