Filter out as value for a variable

Author: timkraut

.gitignore

@@ -2,3 +2,4 @@ node_modules/
 dist/
 *.sublime*
 .idea/
+*.iml

CHANGELOG.md

@@ -1,4 +1,8 @@
 # Changelog
+
+## 3.1.6
+* Filter out `#` as value for a variable
+
 ## 3.1.5
 * Reverts `3.1.4`. We aren't able to find a way to support automatic handling of values containing `,` that isn't full of edge cases. The recommendation remains to wrap such values in single quotes if they're meant to be interpreted as strings.
 

src/index.js

@@ -43,6 +43,7 @@ export function isJSONfile(url) {
 export function transformJSONtoSass(json) {
   return Object.keys(json)
     .filter(key => isValidKey(key))
+    .filter(key => json[key] !== '#')
     .map(key => `$${key}: ${parseValue(json[key])};`)
     .join('\n');
 }

test/fixtures-json5/invalid-variables/variables.json5

@@ -3,4 +3,5 @@
   "@not-valid": "123", // Not valid because of the leading @
   ":not-valid": "123", // Not valid because of the leading :
   "$not-valid": "123", // Not valid because of the leading $
+  "invalid-value": "#", // Not valid because of `#` as value
 }

test/fixtures/invalid-variables/variables.json

@@ -2,5 +2,6 @@
   "colors": "",
   "@not-valid": "123",
   ":not-valid": "123",
-  "$not-valid": "123"
+  "$not-valid": "123",
+  "invalid-value": "#"
 }

test/index.js

@@ -118,6 +118,15 @@ describe('Import type test (JSON)', function() {
 
     expect(result.css.toString()).to.eql('body {\n  color: ""; }\n');
   });
+
+  it('filters out `#` as variable value', function() {
+    let result = sass.renderSync({
+      file: './test/fixtures-json5/invalid-variables/style.scss',
+      importer: jsonImporter,
+    });
+
+    expect(result.css.toString()).to.eql('body {\n  color: ""; }\n');
+  });
 });
 
 describe('Import type test (JSON5)', function() {
@@ -210,6 +219,15 @@ describe('Import type test (JSON5)', function() {
 
     expect(result.css.toString()).to.eql('body {\n  color: ""; }\n');
   });
+
+  it('filters out `#` as variable value', function() {
+    let result = sass.renderSync({
+      file: './test/fixtures-json5/invalid-variables/style.scss',
+      importer: jsonImporter,
+    });
+
+    expect(result.css.toString()).to.eql('body {\n  color: ""; }\n');
+  });
 });
 
 describe('parseValue', function() {
@@ -226,8 +244,9 @@ describe('parseValue', function() {
   });
 
   it('returns the raw value if not an array, object or empty string', function() {
-    expect(123).to.eql(123);
+    expect(parseValue(123)).to.eql(123);
   });
+
   it('can parse nested maps with invalid keys', function() {
     const nestedWithInvalid = {
       inner: {