Skip to content

Commit bf61b7a

Browse files
Merge branch 'dev'
2 parents 0f857b9 + f4cc5ae commit bf61b7a

File tree

8 files changed

+45
-9
lines changed

8 files changed

+45
-9
lines changed

Diff for: CHANGELOG.json

+15
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
11
{
22
"versions": [
3+
{
4+
"version": "3.18.1",
5+
"changes": {
6+
"new": [],
7+
"enhancements": [],
8+
"fixes": [
9+
"`FilePicker`: Fix issue with adding link by typing in 'From a link' tab [#1814](https://github.com/pnp/sp-dev-fx-controls-react/pull/1814)",
10+
"Update nl-nl.ts [#1823](https://github.com/pnp/sp-dev-fx-controls-react/pull/1823)"
11+
]
12+
},
13+
"contributions": [
14+
"[Antanina Druzhkina](https://github.com/Ateina)",
15+
"[Elio Struyf](https://github.com/estruyf)"
16+
]
17+
},
318
{
419
"version": "3.18.0",
520
"changes": {

Diff for: CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# Releases
22

3+
## 3.18.1
4+
5+
### Fixes
6+
7+
- `FilePicker`: Fix issue with adding link by typing in 'From a link' tab [#1814](https://github.com/pnp/sp-dev-fx-controls-react/pull/1814)
8+
- Update nl-nl.ts [#1823](https://github.com/pnp/sp-dev-fx-controls-react/pull/1823)
9+
10+
### Contributors
11+
12+
Special thanks to our contributors (in alphabetical order): [Antanina Druzhkina](https://github.com/Ateina), [Elio Struyf](https://github.com/estruyf).
13+
314
## 3.18.0
415

516
### Enhancements

Diff for: docs/documentation/docs/about/release-notes.md

+11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# Releases
22

3+
## 3.18.1
4+
5+
### Fixes
6+
7+
- `FilePicker`: Fix issue with adding link by typing in 'From a link' tab [#1814](https://github.com/pnp/sp-dev-fx-controls-react/pull/1814)
8+
- Update nl-nl.ts [#1823](https://github.com/pnp/sp-dev-fx-controls-react/pull/1823)
9+
10+
### Contributors
11+
12+
Special thanks to our contributors (in alphabetical order): [Antanina Druzhkina](https://github.com/Ateina), [Elio Struyf](https://github.com/estruyf).
13+
314
## 3.18.0
415

516
### Enhancements

Diff for: package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@pnp/spfx-controls-react",
33
"description": "Reusable React controls for SharePoint Framework solutions",
4-
"version": "3.18.0",
4+
"version": "3.18.1",
55
"node": ">=16.13.0 <17.0.0 || >=18.17.1 <19.0.0",
66
"scripts": {
77
"build": "gulp build",

Diff for: src/common/telemetry/version.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export const version: string = "3.18.0";
1+
export const version: string = "3.18.1";

Diff for: src/controls/filePicker/LinkFilePickerTab/LinkFilePickerTab.tsx

+3-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ export default class LinkFilePickerTab extends React.Component<ILinkFilePickerTa
3434
className={styles.linkTextField}
3535
label={strings.LinkFileInstructions}
3636
ariaLabel={strings.LinkFileInstructions}
37-
defaultValue={"https://"}
3837
onGetErrorMessage={(value: string) => this._getErrorMessagePromise(value)}
3938
autoAdjustHeight={false}
4039
underlined={false}
@@ -64,7 +63,7 @@ export default class LinkFilePickerTab extends React.Component<ILinkFilePickerTa
6463
* Called as user types in a new value
6564
*/
6665
private _handleChange = (fileUrl: string): void => {
67-
const filePickerResult: IFilePickerResult = fileUrl && this._isUrl(fileUrl) ? {
66+
const filePickerResult: IFilePickerResult = fileUrl ? {
6867
fileAbsoluteUrl: fileUrl,
6968
fileName: GeneralHelper.getFileNameFromUrl(fileUrl),
7069
fileNameWithoutExtension: GeneralHelper.getFileNameWithoutExtension(fileUrl),
@@ -81,15 +80,15 @@ export default class LinkFilePickerTab extends React.Component<ILinkFilePickerTa
8180
*/
8281
private _getErrorMessagePromise = async (value: string): Promise<string> => {
8382
// DOn't give an error for blank or placeholder value, but don't make it a valid entry either
84-
if (value === undefined || value === 'https://') {
83+
if (value === undefined || value === '') {
8584
this.setState({ isValid: false });
8685
return '';
8786
}
8887

8988
// Make sure that user is typing a valid URL format
9089
if (!this._isUrl(value)) {
9190
this.setState({ isValid: false });
92-
return '';
91+
return strings.InvalidUrlError;
9392
}
9493

9594
// If we don't allow external links, verify that we're in the same domain

Diff for: src/loc/nl-nl.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ define([], () => {
145145
"HighlightColorTeal": "Taling",
146146
"HighlightColorDarkgreen": "Donkergroen",
147147
"HighlightColorPurple": "Paarse",
148-
"HighlightColorMaroon": "Bosneger",
148+
"HighlightColorMaroon": "Kastanjebruin",
149149
"HighlightColorGold": "Goud",
150150
"HighlightColorDarkgrey": "Donkergrijs",
151151
"HighlightColorGrey": "Grijs",

0 commit comments

Comments
 (0)