PeoplePicker not compatible with SharePoint 1.19?

[EA12]

Category

[ ] Enhancement

[x ] Bug

[ ] Question

Version

@pnp/spfx-controls-react": "^3.18.1

Expected / Desired Behavior / Question

It should be possible to assign the context to the PeoplePicker like described in the documentation:
const peoplePickerContext: IPeoplePickerContext = { absoluteUrl: props.ctx.pageContext.web.absoluteUrl, msGraphClientFactory: props.ctx.msGraphClientFactory, spHttpClient: props.ctx.spHttpClient };

Observed Behavior

I get this message:
Type 'import("c:/Projekte/SPFx/AM/node_modules/@microsoft/sp-http-msgraph/dist/index-internal").MSGraphClientFactory' is not assignable to type 'import("c:/Projekte/SPFx/AM/node_modules/@pnp/spfx-controls-react/node_modules/@microsoft/sp-http-msgraph/dist/index-internal").MSGraphClientFactory'.
Types have separate declarations of a private property '_serviceScope'.ts(2322)
IPeoplePickerContext.d.ts(13, 5): The expected type comes from property 'msGraphClientFactory' which is declared here on type 'IPeoplePickerContext'
(property) IPeoplePickerContext.msGraphClientFactory: MSGraphClientFactory

Steps to Reproduce

Create a new SPFx-Solution (WebPart with React) and install the latest @pnp/spfx-controls-react which is currently "3.18.1"
Impelement a PeoplePicker like described in your documentation: https://pnp.github.io/sp-dev-fx-controls-react/controls/PeoplePicker/

If you verify sp-http-msgraph with
npm list @microsoft/sp-http-msgraph
you will see this:

├── @microsoft/sp-http-msgraph@1.19.0 ├─┬ @microsoft/sp-http@1.19.0 │ └── @microsoft/sp-http-msgraph@1.19.0 deduped └─┬ @pnp/spfx-controls-react@3.18.1 ├─┬ @microsoft/sp-adaptive-card-extension-base@1.18.2 │ └─┬ @microsoft/sp-http@1.18.2 │ └── @microsoft/sp-http-msgraph@1.18.2 ├─┬ @microsoft/sp-dialog@1.18.2 │ └─┬ @microsoft/sp-application-base@1.18.2 │ └─┬ @microsoft/sp-http@1.18.2 │ └── @microsoft/sp-http-msgraph@1.18.2

From my package.json:

"dependencies": { "@fluentui/react": "8.106.4", "@microsoft/sp-core-library": "1.19.0", "@microsoft/sp-lodash-subset": "1.19.0", "@microsoft/sp-office-ui-fabric-core": "1.19.0", "@microsoft/sp-property-pane": "1.19.0", "@microsoft/sp-webpart-base": "1.19.0", "@microsoft/sp-http": "1.19.0", "@microsoft/sp-http-msgraph": "1.19.0", "@pnp/sp": "^4.3.0", "@pnp/spfx-controls-react": "^3.18.1", ...

So it seems that "@pnp/spfx-controls-react@3.18.1" is using @microsoft/sp-http@1.18.2 and not version "1.19.0"
Can bring bring some light on this?

Thanks!

[EA12]

It seems that you added the support for 1.19. into the latest beta version? like stated here - is that true? And when will that come to release version?

[EA12]

I can confirm that it is working with the beta.
But when will this functionality come to a release version?

[michaelmaillot]

Hi @EA12,

3.19.0 has been released: https://www.npmjs.com/package/@pnp/spfx-controls-react/v/3.19.0

Can you give a try and confirm that it's working now on your 1.19.0 SPFx project?

[kitzler-walli]

The problem still exists in version 3.19.0 with the current spfx version

[michaelmaillot]

Hi @kitzler-walli,

I tried with latest version of the Controls (3.20.0) which is based on SPFx 1.20.0 without any issue.

Do you still have the issue and if so, would you mind providing additional info (versions of SPFx + PnP Controls for example)?

@EA12 do you still have compatibility issues?

[michaelmaillot]

Closing this, feel free to reopen it if needed.

[EA12]

Hi @michaelmaillot : Still not working with 1.19.0 and 3.18.1
See my findings in #1853

It is all about the context and this.context.absoluteUrl is undefined