Add xcm recorder to all runtimes #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x3c41a
approved these changes
Feb 4, 2025
acatangiu
approved these changes
Feb 4, 2025
pandres95
approved these changes
Feb 5, 2025
bkontur
reviewed
Feb 5, 2025
| @@ -189,7 +189,7 @@ pub struct XcmConfig; | |||
| impl xcm_executor::Config for XcmConfig { | |||
| type RuntimeCall = RuntimeCall; | |||
| type XcmSender = XcmRouter; | |||
| type XcmRecorder = (); | |||
| type XcmRecorder = XcmPallet; | |||
There was a problem hiding this comment.
maybe we could regenerate xcm weights also, this adds one more read :),
but also we can leave it to the next time
bkontur
approved these changes
Feb 5, 2025
Yes |
bkchr
approved these changes
Feb 7, 2025
|
/merge |
|
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
XcmRecorderconfig item is necessary for theDryRunApito return thelocal_xcm.pallet-xcmcan be used as the implementation.Added it to all runtimes.