Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome not published #2

Open
didix16 opened this issue Jan 17, 2020 · 1 comment
Open

FontAwesome not published #2

didix16 opened this issue Jan 17, 2020 · 1 comment

Comments

@didix16
Copy link

didix16 commented Jan 17, 2020

Hello. I just installed your package but there seems a problem gathering the font awesome.

image

As you can see, the icon is not render properly.

The component is trying to get from a URL that Laravel can't reach.

image

I suggest you that put on your README.md:

Add this line in webpack.mix.js:

.copy("./vendor/pos-lifestyle/laravel-nova-collapsible-sidebar/dist/fonts", "public/fonts")

And then run:

npm run dev
@didix16 didix16 closed this as completed Jan 17, 2020
@didix16 didix16 reopened this Jan 17, 2020
@adriaanzon
Copy link

What about using plain SVG Heroicons instead of Font Awesome, as suggested in Nova's documentation? Font Awesome feels like a heavy dependency anyway, considering it's only used for three icons.

The new heroicons set contains several icons this package could use:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants