Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pyOpenSci review] add missing type annotation in cols_align() method #541

Closed
rich-iannone opened this issue Dec 2, 2024 · 1 comment
Closed

[pyOpenSci review] add missing type annotation in cols_align() method #541

rich-iannone opened this issue Dec 2, 2024 · 1 comment
Labels
pyOpenSci Review

Comments

@rich-iannone
Copy link
Member

From the pyOpenSci comment:

issue (_boxhead.py): The type annotation for cols_align is missing | None for the columns parameter.

pyOpenSci/software-submission#202 (comment)
@rich-iannone
Copy link
Member Author

The cols_align()method is columns: SelectExpr = None and SelectExpr already allows for a None value as requested.

great-tables/great_tables/_boxhead.py

Line 159 in 0e7843e

def cols_align(self: GTSelf, align: str = "left", columns: SelectExpr = None) -> GTSelf:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pyOpenSci Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rich-iannone