Skip to content

Do not show editor action bar for auxiliary windows in compact mode #10988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliasilge merged 1 commit into from
Dec 8, 2025
Merged

Do not show editor action bar for auxiliary windows in compact mode #10988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions src/vs/workbench/browser/parts/editor/editorActionBarControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ import { IConfigurationService } from '../../../../platform/configuration/common
import { IInstantiationService } from '../../../../platform/instantiation/common/instantiation.js';
import { SettingsEditor2Input } from '../../../services/preferences/common/preferencesEditorInput.js';
import { NotebookOutputEditorInput } from '../../../contrib/notebook/browser/outputEditor/notebookOutputEditorInput.js';
import { PositronPlotsEditorInput } from '../../../contrib/positronPlotsEditor/browser/positronPlotsEditorInput.js';
import { IsCompactTitleBarContext } from '../../../common/contextkeys.js';
import { IsAuxiliaryWindowContext, IsCompactTitleBarContext } from '../../../common/contextkeys.js';

/**
* Constants.
Expand Down Expand Up @@ -232,19 +231,18 @@ export class EditorActionBarControlFactory {
return;
}

// Notebooks always disable the editor action bar.
if (editorInput.typeId === NotebookEditorInput.ID || editorInput.typeId === NotebookOutputEditorInput.ID) {
// Auxiliary windows in compact mode always disable the editor action bar.
const isAuxiliaryWindow = IsAuxiliaryWindowContext.getValue(this._contextKeyService);
const isCompact = IsCompactTitleBarContext.getValue(this._contextKeyService);
if (isAuxiliaryWindow && isCompact) {
this.updateEnablement(false);
return;
}

// Plots in compact windows disable the editor action bar.
if (editorInput.typeId === PositronPlotsEditorInput.TypeID) {
const isCompact = IsCompactTitleBarContext.getValue(this._contextKeyService);
if (isCompact) {
this.updateEnablement(false);
return;
}
// Notebooks always disable the editor action bar.
if (editorInput.typeId === NotebookEditorInput.ID || editorInput.typeId === NotebookOutputEditorInput.ID) {
this.updateEnablement(false);
return;
}

// Settings always enables editor action bar.
Expand Down
Loading