Skip to content

PostgresNode and ConnectionParams #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmitry-lipetsk opened this issue May 1, 2025 · 0 comments · May be fixed by #245
Open

PostgresNode and ConnectionParams #244

dmitry-lipetsk opened this issue May 1, 2025 · 0 comments · May be fixed by #245
Assignees

Comments

@dmitry-lipetsk
Copy link
Collaborator

dmitry-lipetsk commented May 1, 2025

Hello All,

I offer to do not use ConnectionParams object in PostgresNode.

PostgresNode must use os_ops instead.

What does it mean?

It means that if you want to use PostgresNode with RemoteOperations object, you have to explicitly create RemoteOperations object and use it to create PostgresNode object.

It allows us to create more clear/exact/simple code. Now we can to create PostgresNode to work with remote host by two ways - through conn_params and through using of prepared os_ops object. New code will allow only one way - through os_ops.

To backward compatibility we can save conn_params parameter in PostgresNode constructor with None default value and verification that it is None. In the future conn_params will be removed at all.

Also, if we want to pass port_manager to PostgresNode constructor, we have to pass valid os_ops parameter, too. This will be checked in new code.

@dmitry-lipetsk dmitry-lipetsk self-assigned this May 1, 2025
dmitry-lipetsk added a commit to dmitry-lipetsk/testgres that referenced this issue May 1, 2025
This patch implements the proposal postgrespro#244 - detach PostgresNode from ConnectionParams object.

It will use os_ops object only.
@dmitry-lipetsk dmitry-lipetsk linked a pull request May 1, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant