[FIX] cURL code snippet contains encoded value for special char + instead of char itself (#735)

* IMPORT-1337 do not encode + in query param

* included in test

* Added changes and test for all the codegens

Author: aman-v-singh

codegens/curl/lib/util.js

@@ -214,7 +214,7 @@ var self = module.exports = {
   },
 
   /**
-   * Encode param except the following characters- [,{,},],%
+   * Encode param except the following characters- [,{,},],%,+
    *
    * @param {String} param
    * @returns {String}
@@ -225,6 +225,7 @@ var self = module.exports = {
       .replace(/%7B/g, '{')
       .replace(/%5D/g, ']')
       .replace(/%7D/g, '}')
+      .replace(/%2B/g, '+')
       .replace(/%25/g, '%')
       .replace(/'/g, '%27');
   },

codegens/curl/test/unit/convert.test.js

@@ -676,12 +676,12 @@ describe('curl convert function', function () {
 
         it('should not encode unresolved query params and ' +
         'encode every other query param, both present together', function () {
-          rawUrl = 'https://postman-echo.com/get?key1={{value}}&key2=\'a b c\'';
+          rawUrl = 'https://postman-echo.com/get?key1={{value}}&key2=\'a b+c\'';
           urlObject = new sdk.Url(rawUrl);
           outputUrlString = getUrlStringfromUrlObject(urlObject);
           expect(outputUrlString).to.not.include('key1=%7B%7Bvalue%7B%7B');
-          expect(outputUrlString).to.not.include('key2=\'a b c\'');
-          expect(outputUrlString).to.equal('https://postman-echo.com/get?key1={{value}}&key2=%27a%20b%20c%27');
+          expect(outputUrlString).to.not.include('key2=\'a b+c\'');
+          expect(outputUrlString).to.equal('https://postman-echo.com/get?key1={{value}}&key2=%27a%20b+c%27');
         });
 
         it('should not encode query params that are already encoded', function () {

codegens/golang/lib/util.js

@@ -109,7 +109,7 @@ const self = module.exports = {
   },
 
   /**
-   * Encode param except the following characters- [,{,},],%
+   * Encode param except the following characters- [,{,},],%,+
    *
    * @param {String} param
    * @returns {String}
@@ -120,6 +120,7 @@ const self = module.exports = {
       .replace(/%7B/g, '{')
       .replace(/%5D/g, ']')
       .replace(/%7D/g, '}')
+      .replace(/%2B/g, '+')
       .replace(/%25/g, '%')
       .replace(/'/g, '%27');
   },

codegens/golang/test/unit/convert.test.js

@@ -1,6 +1,7 @@
 var expect = require('chai').expect,
   sdk = require('postman-collection'),
-  convert = require('../../index').convert;
+  convert = require('../../index').convert,
+  getUrlStringfromUrlObject = require('../../lib/util').getUrlStringfromUrlObject;
 
 describe('Golang convert function', function () {
   describe('Convert function', function () {
@@ -253,5 +254,15 @@ describe('Golang convert function', function () {
         });
       });
     });
+
+    it('should not encode unresolved query params and ' +
+    'encode every other query param, both present together', function () {
+      let rawUrl = 'https://postman-echo.com/get?key1={{value}}&key2=\'a b+c\'',
+        urlObject = new sdk.Url(rawUrl),
+        outputUrlString = getUrlStringfromUrlObject(urlObject);
+      expect(outputUrlString).to.not.include('key1=%7B%7Bvalue%7B%7B');
+      expect(outputUrlString).to.not.include('key2=\'a b+c\'');
+      expect(outputUrlString).to.equal('https://postman-echo.com/get?key1={{value}}&key2=%27a%20b+c%27');
+    });
   });
 });

codegens/java-unirest/lib/parseRequest.js

@@ -3,7 +3,7 @@ var _ = require('./lodash'),
   sanitize = require('./util').sanitize;
 
 /**
- * Encode param except the following characters- [,],%
+ * Encode param except the following characters- [,],%,+
  * Characters { and } are kept encoded because unirest does not support them
  *
  * @param {String} param
@@ -13,6 +13,7 @@ function encodeParam (param) {
   return encodeURIComponent(param)
     .replace(/%5B/g, '[')
     .replace(/%5D/g, ']')
+    .replace(/%2B/g, '+')
     .replace(/%25/g, '%')
     .replace(/'/g, '%27');
 }

codegens/java-unirest/test/unit/convert.test.js

@@ -500,12 +500,12 @@ describe('java unirest convert function for test collection', function () {
 
       it('should not encode unresolved query params and ' +
       'encode every other query param, both present together', function () {
-        rawUrl = 'https://postman-echo.com/get?key1={{value}}&key2=\'a b c\'';
+        rawUrl = 'https://postman-echo.com/get?key1={{value}}&key2=\'a b+c\'';
         urlObject = new sdk.Url(rawUrl);
         outputUrlString = getUrlStringfromUrlObject(urlObject);
         expect(outputUrlString).to.include('key1=%7B%7Bvalue%7D%7D');
-        expect(outputUrlString).to.not.include('key2=\'a b c\'');
-        expect(outputUrlString).to.equal('https://postman-echo.com/get?key1=%7B%7Bvalue%7D%7D&key2=%27a%20b%20c%27');
+        expect(outputUrlString).to.not.include('key2=\'a b+c\'');
+        expect(outputUrlString).to.equal('https://postman-echo.com/get?key1=%7B%7Bvalue%7D%7D&key2=%27a%20b+c%27');
       });
 
       it('should discard disabled query params', function () {

codegens/js-xhr/lib/util.js

@@ -158,7 +158,7 @@ const self = module.exports = {
   },
 
   /**
-   * Encode param except the following characters- [,{,},],%
+   * Encode param except the following characters- [,{,},],%,+
    *
    * @param {String} param
    * @returns {String}
@@ -169,6 +169,7 @@ const self = module.exports = {
       .replace(/%7B/g, '{')
       .replace(/%5D/g, ']')
       .replace(/%7D/g, '}')
+      .replace(/%2B/g, '+')
       .replace(/%25/g, '%')
       .replace(/'/g, '%27');
   },

codegens/js-xhr/test/unit/convert.test.js

@@ -1,7 +1,7 @@
 var expect = require('chai').expect,
   sdk = require('postman-collection'),
   sanitize = require('../../lib/util.js').sanitize,
-
+  getUrlStringfromUrlObject = require('../../lib/util').getUrlStringfromUrlObject,
   convert = require('../../index').convert,
   getOptions = require('../../index').getOptions;
 
@@ -162,6 +162,15 @@ describe('js-xhr convert function', function () {
     it('should trim input string when needed', function () {
       expect(sanitize('inputString     ', true)).to.equal('inputString');
     });
+    it('should not encode unresolved query params and ' +
+    'encode every other query param, both present together', function () {
+      let rawUrl = 'https://postman-echo.com/get?key1={{value}}&key2=\'a b+c\'',
+        urlObject = new sdk.Url(rawUrl),
+        outputUrlString = getUrlStringfromUrlObject(urlObject);
+      expect(outputUrlString).to.not.include('key1=%7B%7Bvalue%7B%7B');
+      expect(outputUrlString).to.not.include('key2=\'a b+c\'');
+      expect(outputUrlString).to.equal('https://postman-echo.com/get?key1={{value}}&key2=%27a%20b+c%27');
+    });
   });
 
   describe('POST Form data Request', function () {

codegens/libcurl/lib/util.js

@@ -160,7 +160,7 @@ const self = module.exports = {
   },
 
   /**
-   * Encode param except the following characters- [,{,},],%
+   * Encode param except the following characters- [,{,},],%,+
    *
    * @param {String} param
    * @returns {String}
@@ -171,6 +171,7 @@ const self = module.exports = {
       .replace(/%7B/g, '{')
       .replace(/%5D/g, ']')
       .replace(/%7D/g, '}')
+      .replace(/%2B/g, '+')
       .replace(/%25/g, '%')
       .replace(/'/g, '%27');
   },

codegens/libcurl/test/unit/convert.test.js

@@ -2,6 +2,7 @@ var expect = require('chai').expect,
   sdk = require('postman-collection'),
   convert = require('../../index').convert,
   getOptions = require('../../index').getOptions,
+  getUrlStringfromUrlObject = require('../../lib/util').getUrlStringfromUrlObject,
   sanitize = require('../../lib/util').sanitize,
   mainCollection = require('../../../../test/codegen/newman/fixtures/basicCollection.json');
 
@@ -207,5 +208,14 @@ describe('libcurl convert function', function () {
       expect(sanitize('inputString     ', true)).to.equal('inputString');
     });
 
+    it('should not encode unresolved query params and ' +
+    'encode every other query param, both present together', function () {
+      let rawUrl = 'https://postman-echo.com/get?key1={{value}}&key2=\'a b+c\'',
+        urlObject = new sdk.Url(rawUrl),
+        outputUrlString = getUrlStringfromUrlObject(urlObject);
+      expect(outputUrlString).to.not.include('key1=%7B%7Bvalue%7B%7B');
+      expect(outputUrlString).to.not.include('key2=\'a b+c\'');
+      expect(outputUrlString).to.equal('https://postman-echo.com/get?key1={{value}}&key2=%27a%20b+c%27');
+    });
   });
 });