We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are a few cases strictly prohibited by the reflection-based dependency injection: https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework/Allocation/CachedAttribute.cs https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework/Allocation/ResolvedAttribute.cs https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework/Allocation/BackgroundDependencyLoaderAttribute.cs
The source generator does not, and cannot validate these scenarios itself. Instead, it needs an analyser component to look for incorrect usages.
Tests for the above cases are currently ignored: https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework.Tests/Dependencies/SourceGeneration/CachedAttributeTest.cs https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework.Tests/Dependencies/SourceGeneration/ResolvedAttributeTest.cs https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework.Tests/Dependencies/SourceGeneration/DependencyContainerTest.cs
It should be fairly easy/performant to do this since these are completely syntactical validations.
This came up in ppy/osu#24303
The text was updated successfully, but these errors were encountered:
No branches or pull requests
There are a few cases strictly prohibited by the reflection-based dependency injection:
https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework/Allocation/CachedAttribute.cs
https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework/Allocation/ResolvedAttribute.cs
https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework/Allocation/BackgroundDependencyLoaderAttribute.cs
The source generator does not, and cannot validate these scenarios itself. Instead, it needs an analyser component to look for incorrect usages.
Tests for the above cases are currently ignored:
https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework.Tests/Dependencies/SourceGeneration/CachedAttributeTest.cs
https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework.Tests/Dependencies/SourceGeneration/ResolvedAttributeTest.cs
https://github.com/ppy/osu-framework/blob/07236add353352ff47c52995f39bae155b5f4d4c/osu.Framework.Tests/Dependencies/SourceGeneration/DependencyContainerTest.cs
It should be fairly easy/performant to do this since these are completely syntactical validations.
This came up in ppy/osu#24303
The text was updated successfully, but these errors were encountered: