Skip to content

Beatmapsets not fully marked as deleted in some cases #13143

Description

@cl8n

I found this strange behavior on some maps that 404 from BeatmapsetsController::show() but still can be found in routes that directly query Beatmapset::findOrFail()

example:
https://osu.ppy.sh/beatmapsets/1537149 (404)
https://osu.ppy.sh/beatmapsets/1537149/discussion-last-update (200)
https://osu.ppy.sh/users/19168645#beatmaps (the oldest graveyarded map on this page)

compare to a more "expected" result:
https://osu.ppy.sh/beatmapsets/1537153 (404)
https://osu.ppy.sh/beatmapsets/1537153/discussion-last-update (404)

(if you have moderator permissions these results may be different, this is for a regular user)

from what I can tell the only way this can happen is if the beatmapset has no beatmaps, but is still active=1 deleted_at=null. it feels like they're "supposed" to be marked as deleted given they are usually treated as such. i won't list it all here but there are some clearly unintended behaviors possible for maps in this state, one of which being that you can download them, which is how i found the associated creator

I also wonder if this has second-order effects such as comments or topics on affected maps not being deleted, but I have no reasonable way to check

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions