config.h: Align mldsa-native and mlkem-native config.h #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
changed the title
mkannwischer
requested changes
Nov 28, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Please squash your autogen commit into the previous commit.
Also why is there no MLD_CONFIG_MONOBUILD_KEEP_SHARED_HEADERS in mldsa-native? Could you add that in a separate commit please?
If I see correctly, then MLK_CONFIG_NO_ASM_VALUE_BARRIER is missing in mlkem-native? Could you open a PR there, please? The MLK_CONFIG_NO_ASM_VALUE_BARRIER", # TODO: Add to config? can re removed then.
willieyz
force-pushed
the
align-config
branch
from
d4a8a32 to
1ad0e60
Compare
mkannwischer
requested changes
Nov 28, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Please read my previous comment and address it.
willieyz
force-pushed
the
align-config
branch
from
1ad0e60 to
4b8582d
Compare
Contributor
Author
|
Hello, @mkannwischer , thank you for your review!
|
mkannwischer
approved these changes
Dec 3, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @willieyz. LGTM.
mkannwischer
force-pushed
the
align-config
branch
from
4b8582d to
a4b1b29
Compare
…in config.h Signed-off-by: willieyz <[email protected]>
- This commit add missing MLD_CONFIG_MONOBUILD_KEEP_SHARED_HEADERS and remove following from autogen: `"MLD_CONFIG_NO_ASM_VALUE_BARRIER", # TODO: Add to config?` Signed-off-by: willieyz <[email protected]>
mkannwischer
force-pushed
the
align-config
branch
from
a4b1b29 to
6aad424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: config.h: Align the divergence between mldsa-native and mlkem-native in config.h #688
This PR aligns the config.h differences between mldsa-native and mlkem-native.
For example, In mlkem-native, MLK_CONFIG_FILE is the second entry, while in mldsa-native, MLD_CONFIG_FILE was moved to the fifth position and mixed with native-backend configuration macros.
Aligning these discrepancies simplifies future porting and modifications, and helps prevent issues like the missing macros fixed in config.h: Add missing MLD_CONFIG_USE_NATIVE_BACKEND_FIPS202/ARITH #686.
The following discrepancies also had been addressed:
MLD_CONFIG_MONOBUILD_KEEP_SHARED_HEADERSmissing in mldsa-native, fixed.MLK_CONFIG_NO_ASM_VALUE_BARRIERmissing in mlkem-native, fixed in mlkem-naitve PR #1325