fix: Adapt http2 connection for Node.js 8.11.2 and Node.js 10

Node.js 8.11.2 and Node.js 10 do not trigger the "close" event on
the socket any more. Also, there is new method "close" on the http2
client, which replaces the earlier (still existing) "destroy".
The complete end of the end of the http2 communication can be caught
only in the callback of the "close" or "destroy" methods and not in
the "close" event handler on the socket any more.

Author: prantlf

lib/nettime.js

@@ -46,7 +46,7 @@ function nettime (options) {
         prolog.push(os.EOL)
         data = Buffer.concat([Buffer.from(prolog.join(os.EOL)), data])
       }
-      return new Promise(resolve => {
+      return new Promise(resolve =>
         fs.writeFile(outputFile, data, error => {
           if (error) {
             if (options.failOnOutputFileError === false) {
@@ -57,8 +57,7 @@ function nettime (options) {
             }
           }
           resolve()
-        })
-      })
+        }))
     }
 
     function listenToSocket (socket) {
@@ -72,14 +71,7 @@ function nettime (options) {
         .on('secureConnect', () => {
           timings.tlsHandshake = getTiming()
         })
-        .on('close', () => {
-          timings.socketClose = getTiming()
-          if (outputFile && data) {
-            writeOutputFile().then(returnResult)
-          } else {
-            returnResult()
-          }
-        })
+        .on('close', checkSocketClosed)
     }
 
     function listenToResponse (response) {
@@ -103,6 +95,18 @@ function nettime (options) {
       }
     }
 
+    let socketClosed
+    function checkSocketClosed () {
+      if (!socketClosed) {
+        timings.socketClose = getTiming()
+        if (outputFile && data) {
+          writeOutputFile().then(returnResult)
+        } else {
+          returnResult()
+        }
+      }
+    }
+
     const parameters = getParameters()
     const httpVersion = options.httpVersion
     const scheme = parameters.protocol
@@ -148,7 +152,8 @@ function nettime (options) {
           }
         })
       listenToResponse(request)
-      request.on('end', () => client.destroy())
+      request.on('end', () =>
+        (client.close || client.destroy).call(client, checkSocketClosed))
         .setEncoding('utf8')
     } else {
       request = protocol.request(parameters, (localResponse) => {