Skip to content

Commit d8906e9

Browse files
rschristianJoviDeCroock
authored andcommitted
refactor: Skip dom check for inferring lower-cased event names (#4720)
1 parent e897955 commit d8906e9

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

src/diff/props.js

+2-7
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,8 @@ export function setProperty(dom, name, value, oldValue, namespace) {
6666
else if (name[0] == 'o' && name[1] == 'n') {
6767
useCapture = name != (name = name.replace(CAPTURE_REGEX, '$1'));
6868

69-
// Infer correct casing for DOM built-in events:
70-
if (
71-
name.toLowerCase() in dom ||
72-
name == 'onFocusOut' ||
73-
name == 'onFocusIn'
74-
)
75-
name = name.toLowerCase().slice(2);
69+
// Infer correct casing for events:
70+
if (name[2].toLowerCase() != name[2]) name = name.toLowerCase().slice(2);
7671
else name = name.slice(2);
7772

7873
if (!dom._listeners) dom._listeners = {};

test/browser/events.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ describe('event handling', () => {
5858
expect(
5959
proto.addEventListener
6060
).to.have.been.calledOnce.and.to.have.been.calledWithExactly(
61-
'OtherClick',
61+
'otherclick',
6262
sinon.match.func,
6363
false
6464
);

0 commit comments

Comments
 (0)