set domain to unknown if not defined and add a warning

Author: t-sormonte

adapters/sparteo/sparteo.go

@@ -2,7 +2,6 @@ package sparteo
 
 import (
 	"fmt"
-	"log"
 	"net/http"
 	"net/url"
 	"strings"
@@ -79,6 +78,12 @@ func (a *adapter) MakeRequests(req *openrtb2.BidRequest, reqInfo *adapters.Extra
 	}
 
 	domain := extractDomain(&request)
+	if strings.TrimSpace(domain) == "" {
+		errs = append(errs, &errortypes.BadInput{
+			Message: "Domain not found. Missing at least one of this fields: site.domain, site.page, app.domain.",
+		})
+		domain = "unknown"
+	}
 
 	var bundle string
 	if request.App != nil {
@@ -138,7 +143,11 @@ func (a *adapter) MakeRequests(req *openrtb2.BidRequest, reqInfo *adapters.Extra
 	} else if request.App != nil {
 		pub = ensurePublisher(&request.App.Publisher)
 		pubExt = "app.publisher.ext"
-	}
+	} else {
+        request.Site = &openrtb2.Site{}
+        pub = ensurePublisher(&request.Site.Publisher)
+        pubExt = "site.publisher.ext"
+    }
 
 	ext, err := updatePublisherExtension(&pub.Ext, networkID, pubExt)
 	if err != nil {
@@ -233,7 +242,6 @@ func extractDomain(req *openrtb2.BidRequest) string {
 }
 
 func ensurePublisher(p **openrtb2.Publisher) *openrtb2.Publisher {
-	log.Println("ensurePublisher", p)
 	if *p == nil {
 		*p = &openrtb2.Publisher{}
 	}
@@ -251,8 +259,6 @@ func updatePublisherExtension(targetExt *jsonutil.RawMessage, networkID, fieldPa
 		pubExt = make(map[string]interface{})
 	}
 
-	log.Println("updatePublisherExtension", pubExt)
-
 	params, ok := pubExt["params"].(map[string]interface{})
 	if !ok {
 		params = make(map[string]interface{})

adapters/sparteo/sparteo_test.go

@@ -3,12 +3,14 @@ package sparteo
 import (
 	"bytes"
 	"encoding/json"
+	"errors"
 	"testing"
 
 	"github.com/prebid/openrtb/v20/openrtb2"
 	"github.com/prebid/prebid-server/v3/adapters"
 	"github.com/prebid/prebid-server/v3/adapters/adapterstest"
 	"github.com/prebid/prebid-server/v3/config"
+	"github.com/prebid/prebid-server/v3/errortypes"
 	"github.com/prebid/prebid-server/v3/openrtb_ext"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -515,3 +517,99 @@ func TestMakeRequests_UpdatePublisherExtension_PrefersSiteOverApp(t *testing.T)
 		assert.False(t, appOk, "app.publisher.ext should not contain networkId when site exists")
 	}
 }
+
+// TestMakeRequests_DomainMissing_WarnsAndUsesUnknown verifies that when no domain can be resolved the domain macro is replaced by unknown
+func TestMakeRequests_DomainMissing_WarnsAndUsesUnknown(t *testing.T) {
+    endpoint := "https://bid-test.sparteo.com/s2s-auction?network_id={{.NetworkId}}&domain={{.Domain}}"
+
+    bidder, err := Builder(openrtb_ext.BidderSparteo, config.Adapter{Endpoint: endpoint}, config.Server{GvlID: 1028})
+    require.NoError(t, err)
+
+    in := &openrtb2.BidRequest{
+        ID: "req-domain-missing",
+        Imp: []openrtb2.Imp{
+            {ID: "imp-1", Ext: json.RawMessage(`{"bidder":{"networkId":"networkID"}}`)},
+        },
+    }
+
+    reqs, errs := bidder.MakeRequests(in, &adapters.ExtraRequestInfo{})
+
+    require.Len(t, reqs, 1)
+    require.Len(t, errs, 1)
+
+    assert.Equal(t,
+        "https://bid-test.sparteo.com/s2s-auction?network_id=networkID&domain=unknown",
+        reqs[0].Uri,
+    )
+
+    var badInput *errortypes.BadInput
+    require.True(t, errors.As(errs[0], &badInput))
+    assert.Contains(t, badInput.Error(), "Domain not found")
+}
+
+// TestMakeRequests_AppBundle_WithMissingDomain_WarnsAndUsesUnknown verifies that when an app is present with a bundle but without a resolvable domain
+func TestMakeRequests_AppBundle_WithMissingDomain_WarnsAndUsesUnknown(t *testing.T) {
+    endpoint := "https://bid-test.sparteo.com/s2s-auction?network_id={{.NetworkId}}&domain={{.Domain}}{{if .Bundle}}&bundle={{.Bundle}}{{end}}"
+
+    bidder, err := Builder(openrtb_ext.BidderSparteo, config.Adapter{Endpoint: endpoint}, config.Server{GvlID: 1028})
+    require.NoError(t, err)
+
+    in := &openrtb2.BidRequest{
+        ID:   "req-app-bundle-no-domain",
+        Site: nil,
+        App: &openrtb2.App{
+            Domain: "",
+            Bundle: "com.sparteo.app",
+            Publisher: &openrtb2.Publisher{},
+        },
+        Imp: []openrtb2.Imp{
+            {ID: "imp-1", Ext: json.RawMessage(`{"bidder":{"networkId":"networkID"}}`)},
+        },
+    }
+
+    reqs, errs := bidder.MakeRequests(in, &adapters.ExtraRequestInfo{})
+
+    require.Len(t, reqs, 1)
+    require.Len(t, errs, 1)
+
+    assert.Equal(t,
+        "https://bid-test.sparteo.com/s2s-auction?network_id=networkID&domain=unknown&bundle=com.sparteo.app",
+        reqs[0].Uri,
+    )
+
+    var badInput *errortypes.BadInput
+    require.True(t, errors.As(errs[0], &badInput))
+    assert.Contains(t, badInput.Error(), "Domain not found")
+}
+
+// TestMakeRequests_SitePageLiteralNull_TreatedAsMissingDomain verifies that a literal "null" value in site.page is treated as an unknown domain. 
+func TestMakeRequests_SitePageLiteralNull_TreatedAsMissingDomain(t *testing.T) {
+    endpoint := "https://bid-test.sparteo.com/s2s-auction?network_id={{.NetworkId}}&domain={{.Domain}}"
+
+    bidder, err := Builder(openrtb_ext.BidderSparteo, config.Adapter{Endpoint: endpoint}, config.Server{GvlID: 1028})
+    require.NoError(t, err)
+
+    in := &openrtb2.BidRequest{
+        ID: "req-page-null",
+        Site: &openrtb2.Site{
+            Domain: "",
+            Page:   "null",
+        },
+        Imp: []openrtb2.Imp{
+            {ID: "imp-1", Ext: json.RawMessage(`{"bidder":{"networkId":"networkID"}}`)},
+        },
+    }
+
+    reqs, errs := bidder.MakeRequests(in, &adapters.ExtraRequestInfo{})
+
+    require.Len(t, reqs, 1)
+    require.Len(t, errs, 1)
+    assert.Equal(t,
+        "https://bid-test.sparteo.com/s2s-auction?network_id=networkID&domain=unknown",
+        reqs[0].Uri,
+    )
+
+    var badInput *errortypes.BadInput
+    require.True(t, errors.As(errs[0], &badInput))
+    assert.Contains(t, badInput.Error(), "Domain not found")
+}

static/bidder-info/sparteo.yaml

@@ -7,14 +7,12 @@ capabilities:
     mediaTypes:
       - banner
       - video
-      - native
   site:
     mediaTypes:
       - banner
       - video
-      - native
-endpoint: "https://bid.sparteo.com/s2s-auction?network_id={{.NetworkId}}&domain={{.Domain}}{{if .Bundle}}&bundle={{.Bundle}}{{end}}"
+endpoint: "http://host.docker.internal:3006/s2s-auction?network_id={{.NetworkId}}&domain={{.Domain}}{{if .Bundle}}&bundle={{.Bundle}}{{end}}"
 userSync:
   iframe:
-    url: "https://sync.sparteo.com/s2s_sync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect_url={{.RedirectURL}}"
-    supportCors: true
+    url: "https://localhost:8843/s2s_sync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect_url={{.RedirectURL}}"
+    supportCors: true