Skip to content

Commit 4bc5af0

Browse files
committed
Increase query.max-memory-per-node to 8GB
1 parent 947ba93 commit 4bc5af0

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

docs/presto-admin-commands.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ For workers: ::
129129
coordinator=false
130130
discovery.uri=http://<coordinator>:8080
131131
http-server.http.port=8080
132-
query.max-memory-per-node=1GB
132+
query.max-memory-per-node=8GB
133133
query.max-memory=50GB
134134

135135
For coordinator: ::
@@ -139,7 +139,7 @@ For coordinator: ::
139139
discovery.uri=http://<coordinator>:8080
140140
http-server.http.port=8080
141141
node-scheduler.include-coordinator=false
142-
query.max-memory-per-node=1GB
142+
query.max-memory-per-node=8GB
143143
query.max-memory=50GB
144144

145145
# if the coordinator is also a worker, it will have the following property instead

prestoadmin/coordinator.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class Coordinator(Node):
5151
'http-server.http.port': '8080',
5252
'node-scheduler.include-coordinator': 'false',
5353
'query.max-memory': '50GB',
54-
'query.max-memory-per-node': '1GB'}
54+
'query.max-memory-per-node': '8GB'}
5555
}
5656

5757
def _get_conf_dir(self):

prestoadmin/workers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class Worker(Node):
5353
'8080',
5454
'query.max-memory': '50GB',
5555
'query.max-memory-per-node':
56-
'1GB'}
56+
'8GB'}
5757
}
5858

5959
def _get_conf_dir(self):

tests/product/base_product_case.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class BaseProductTestCase(BaseTestCase):
6868
default_workers_config_ = """coordinator=false
6969
discovery.uri=http://master:8080
7070
http-server.http.port=8080
71-
query.max-memory-per-node=1GB
71+
query.max-memory-per-node=8GB
7272
query.max-memory=50GB\n"""
7373

7474
default_workers_test_config_ = """coordinator=false
@@ -97,7 +97,7 @@ class BaseProductTestCase(BaseTestCase):
9797
discovery.uri=http://master:8080
9898
http-server.http.port=8080
9999
node-scheduler.include-coordinator=false
100-
query.max-memory-per-node=1GB
100+
query.max-memory-per-node=8GB
101101
query.max-memory=50GB\n"""
102102

103103
default_coordinator_test_config_ = """coordinator=true

tests/unit/test_coordinator.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def test_build_all_defaults(self):
5050
'http-server.http.port': '8080',
5151
'node-scheduler.include-coordinator': 'false',
5252
'query.max-memory': '50GB',
53-
'query.max-memory-per-node': '1GB'}
53+
'query.max-memory-per-node': '8GB'}
5454
}
5555

5656
self.assertEqual(actual_default, expected)
@@ -80,7 +80,7 @@ def test_defaults_coord_is_worker(self):
8080
'http-server.http.port': '8080',
8181
'node-scheduler.include-coordinator': 'true',
8282
'query.max-memory': '50GB',
83-
'query.max-memory-per-node': '1GB'}
83+
'query.max-memory-per-node': '8GB'}
8484
}
8585

8686
self.assertEqual(actual_default, expected)
@@ -164,7 +164,7 @@ def test_get_conf(self, get_conf_from_file_mock, write_mock):
164164
'http-server.http.port': '8080',
165165
'node-scheduler.include-coordinator': 'false',
166166
'query.max-memory': '50GB',
167-
'query.max-memory-per-node': '1GB'}
167+
'query.max-memory-per-node': '8GB'}
168168
}
169169

170170
self.assertEqual(coordinator.Coordinator().get_conf(), expected)

tests/unit/test_workers.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def test_build_defaults(self):
4747
'discovery.uri': 'http://a:8080',
4848
'http-server.http.port': '8080',
4949
'query.max-memory': '50GB',
50-
'query.max-memory-per-node': '1GB'}
50+
'query.max-memory-per-node': '8GB'}
5151
}
5252

5353
self.assertEqual(actual_default, expected)
@@ -125,7 +125,7 @@ def test_get_conf(self, get_presto_conf_mock, write_mock):
125125
'discovery.uri': 'http://j:8080',
126126
'http-server.http.port': '8080',
127127
'query.max-memory': '50GB',
128-
'query.max-memory-per-node': '1GB'}
128+
'query.max-memory-per-node': '8GB'}
129129
}
130130
self.assertEqual(workers.Worker().get_conf(), expected)
131131

0 commit comments

Comments
 (0)