Skip to content

Commit fccaad1

Browse files
author
Eric Diven
committed
Fail build if removing docker images fails in clean-test.
We've been getting into losing streaks where some of the tests consistently fail in automation until they get run on a new Jenkins slave. Anu noticed that the clean-test step was failing to remove docker images; this should be an error in automation. We should never run the product tests with images that we created on a previous run.
1 parent f3f0db8 commit fccaad1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ clean-test:
5656
rm -f .coverage
5757
rm -fr htmlcov/
5858
rm -fr tmp
59-
-for image in $$(docker images | awk '/teradatalabs\/pa_test/ {print $$1}'); do docker rmi -f $$image ; done
59+
for image in $$(docker images | awk '/teradatalabs\/pa_test/ {print $$1}'); do docker rmi -f $$image ; done
6060
@echo "\n\tYou can kill running containers that caused errors removing images by running \`make clean-test-containers'\n"
6161

6262
clean-docs:

0 commit comments

Comments
 (0)