Extract package build from product tests #189
Assignees
Comments
kokosing
added a commit
to Teradata/presto-admin
that referenced
this issue
Jun 28, 2016
Build binary files seems to be a better task for the build tool (like make) than for the product tests framework. Moreover product tests framework was caching the result in the `tmp/installer` directory so when the changes were introduced to presto-admin, package was not rebuild. So it was easy to run product tests with the old version of product-tests. Instead of that building distribution package was moved to Makefile. Moreover, disregarding how this file is created it will be stored in `dist` directory. No more need for having `tmp/installer`. Fixes prestodb#189
kokosing
added a commit
to Teradata/presto-admin
that referenced
this issue
Jun 29, 2016
Build binary files seems to be a better task for the build tool (like make) than for the product tests framework. Moreover product tests framework was caching the result in the `tmp/installer` directory so when the changes were introduced to presto-admin, package was not rebuild. So it was easy to run product tests with the old version of product-tests. Instead of that building distribution package was moved to Makefile. Moreover, disregarding how this file is created it will be stored in `dist` directory. No more need for having `tmp/installer`. Fixes prestodb#189
kokosing
added a commit
to Teradata/presto-admin
that referenced
this issue
Jun 29, 2016
Build binary files seems to be a better task for the build tool (like make) than for the product tests framework. Moreover product tests framework was caching the result in the `tmp/installer` directory so when the changes were introduced to presto-admin, package was not rebuild. So it was easy to run product tests with the old version of product-tests. Instead of that building distribution package was moved to Makefile. Moreover, disregarding how this file is created it will be stored in `dist` directory. No more need for having `tmp/installer`. Fixes prestodb#189
kokosing
added a commit
to Teradata/presto-admin
that referenced
this issue
Jun 30, 2016
Build binary files seems to be a better task for the build tool (like make) than for the product tests framework. Moreover product tests framework was caching the result in the `tmp/installer` directory so when the changes were introduced to presto-admin, package was not rebuild. So it was easy to run product tests with the old version of product-tests. Instead of that building distribution package was moved to Makefile. Moreover, disregarding how this file is created it will be stored in `dist` directory. No more need for having `tmp/installer`. Fixes prestodb#189
kokosing
added a commit
to Teradata/presto-admin
that referenced
this issue
Jul 1, 2016
Build binary files seems to be a better task for the build tool (like make) than for the product tests framework. Moreover product tests framework was caching the result in the `tmp/installer` directory so when the changes were introduced to presto-admin, package was not rebuild. So it was easy to run product tests with the old version of product-tests. Instead of that building distribution package was moved to Makefile. Moreover, disregarding how this file is created it will be stored in `dist` directory. No more need for having `tmp/installer`. Fixes prestodb#189 Pull request: prestodb#195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code under https://github.com/prestodb/presto-admin/blob/master/tests/product/prestoadmin_installer.py#L80 should be extracted as some
make buildcommand. Thanks to that user (developer) has a control when a package is rebuilt.Currently it rebuilds automatically, which is not obvious. I didn't know about that and I took me a some time to investigate how presto admin package is installed on docker.
The text was updated successfully, but these errors were encountered: