You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The presto-admin product tests need to do two things when presto-admin changes:
rebuild presto-admin
remove any docker images from previous tests runs that have the old version of presto-admin installed.
This is currently a little brittle. presto-admin only gets rebuilt if there isn't a dist of it already in existence, which doesn't handle the case where changes have been made but the dist hasn't been removed. Unfortunately, this is a very common case.
Cleaning up docker images used to be done by removing them whenever we rebuild presto-admin, but in the course of refactoring things in preparation for the slider tests, that ceased working because of changes in how we commit containers and when we expect them to exist.
After some discussion, Christina and I agreed that it probably makes sense to just punt the work to get image cleanup working into a future task that also solves the issue of rebuilding presto-admin in a way that handles the aforementioned case of a dist existing but there being changes to pa.
The text was updated successfully, but these errors were encountered:
The presto-admin product tests need to do two things when presto-admin changes:
This is currently a little brittle. presto-admin only gets rebuilt if there isn't a dist of it already in existence, which doesn't handle the case where changes have been made but the dist hasn't been removed. Unfortunately, this is a very common case.
Cleaning up docker images used to be done by removing them whenever we rebuild presto-admin, but in the course of refactoring things in preparation for the slider tests, that ceased working because of changes in how we commit containers and when we expect them to exist.
After some discussion, Christina and I agreed that it probably makes sense to just punt the work to get image cleanup working into a future task that also solves the issue of rebuilding presto-admin in a way that handles the aforementioned case of a dist existing but there being changes to pa.
The text was updated successfully, but these errors were encountered: