Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement robust cleanup and presto-admin update when tests are run through pycharm #231

Open
mattsfuller opened this issue Sep 1, 2016 · 0 comments

Comments

@mattsfuller
Copy link

mattsfuller commented Sep 1, 2016

The presto-admin product tests need to do two things when presto-admin changes:

  1. rebuild presto-admin
  2. remove any docker images from previous tests runs that have the old version of presto-admin installed.

This is currently a little brittle. presto-admin only gets rebuilt if there isn't a dist of it already in existence, which doesn't handle the case where changes have been made but the dist hasn't been removed. Unfortunately, this is a very common case.

Cleaning up docker images used to be done by removing them whenever we rebuild presto-admin, but in the course of refactoring things in preparation for the slider tests, that ceased working because of changes in how we commit containers and when we expect them to exist.

After some discussion, Christina and I agreed that it probably makes sense to just punt the work to get image cleanup working into a future task that also solves the issue of rebuilding presto-admin in a way that handles the aforementioned case of a dist existing but there being changes to pa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant