Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give flexibility to the users by allowing them to specify remote configuration #339

Closed
satheeshravir opened this issue Apr 27, 2017 · 3 comments

Comments

@satheeshravir
Copy link

satheeshravir commented Apr 27, 2017

Grab some of the paths from the environment variables. It give flexibility to the users. For example constants.py can be modified as follows

REMOTE_CONF_DIR = os.environ['PRESTO_REMOTE_CONF_DIR'] if 'PRESTO_REMOTE_CONF_DIR' in os.environ else '/etc/presto'

satheeshravir pushed a commit to satheeshravir/presto-admin that referenced this issue Apr 27, 2017
@rschlussel-zz
Copy link
Member

For variables that get set in Presto config files, I think the right way to do this would be to get the values directly from the config files. e.g. look at remote_config_util.py to see how we do this for the getting the Presto log directories and the catalog directory. Even for these, it looks like in some places in the code the constants get used instead of calling these functions, so those usages just need to be replaced with the appropriate function call.

@rschlussel-zz
Copy link
Member

This is a duplicate of #229

@satheeshravir
Copy link
Author

Thank you for the comment.
I will update the code to fetch values from config files. I will push the changes whenever I get time

satheeshravir pushed a commit to satheeshravir/presto-admin that referenced this issue Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants