Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-py to 2.6.0 from 1.5.0 #348

Closed
kokosing opened this issue Nov 13, 2017 · 3 comments
Closed

Update docker-py to 2.6.0 from 1.5.0 #348

kokosing opened this issue Nov 13, 2017 · 3 comments
Assignees

Comments

@kokosing
Copy link
Contributor

When using current docker version and old docker-py it is possible to get some weird errors. I am getting this one:

"Cannot link to a non running container

Here someone suggest that we sholuld use docker network instead of link.

Update would be nice, but it is hard to tell how much changes are needed to update this lib.

@kokosing kokosing self-assigned this Nov 13, 2017
@petroav
Copy link
Contributor

petroav commented Nov 13, 2017

Are you getting the error while running the product tests?

I feel like as long as the two versions are API compatible everything should work as expected. Did you try a Travis run with the new version?

@kokosing
Copy link
Contributor Author

Yes, I got this error while running product tests. I haven't yet started to do anything with the new version.

@kokosing
Copy link
Contributor Author

Fixed with #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants