-
Notifications
You must be signed in to change notification settings - Fork 32
Add RFC for supporting MCP with Presto #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e00718d to
57e25e0
Compare
| - Implement the core MCP primitives: | ||
| - `tools/list` for tool discovery | ||
| - `tools/call` for executing tools | ||
| - Initially provide a single tool: `query.run`, which executes SQL queries against Presto. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any restriction on the type of queries supported? If it's a DML, might we need a new tool to support it, since they don't return data but return metadata about what was modified?
| - Initially provide a single tool: `query.run`, which executes SQL queries against Presto. | ||
| - Internally communicate with Presto coordinators using standard Presto HTTP APIs. | ||
| - Forward OAuth/JWT Bearer tokens transparently from MCP clients to Presto, ensuring that Presto performs all authentication and authorization checks. | ||
| - Translate between the two protocols, aggregating streaming results into a single response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the query requests too much data and creates memory pressure in the MCP server?
| - Table metadata tools | ||
| - Query explanation tools | ||
|
|
||
| ## WIP - Draft PR Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## WIP - Draft PR Changes |
I presume it's not WIP anymore?
| - Implement the core MCP primitives: | ||
| - `tools/list` for tool discovery | ||
| - `tools/call` for executing tools | ||
| - Initially provide a single tool: `query.run`, which executes SQL queries against Presto. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume this will also run SHOW catalogs; and other statements ?
Add RFC for supporting MCP with Presto