Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prettier.useTabs and prettier.tabWidth #3323

Closed
neorth opened this issue Feb 29, 2024 · 2 comments
Closed

Remove prettier.useTabs and prettier.tabWidth #3323

neorth opened this issue Feb 29, 2024 · 2 comments
Labels
locked Please open a new issue and fill out the template instead of commenting. Stale

Comments

@neorth
Copy link

neorth commented Feb 29, 2024

Is your feature request related to a problem? Please describe.
I have seen confusion around the tab size settings in vscode so many times now and think it's time ro reconsider removing these two prettier settings. The implications around this change was previously discussed in #1515 and the two possible alternatives were clearly explained in this comment: #1515 (comment)

This change would close #1859

Sure, there will be some frustration from those who have previously changed the prettier-specific settings but my guess is those are far fewer than the ones getting confused over why the setting in the status bar doesn't correspond with the actual indentation getting applied by prettier.

Describe the solution you'd like
Remove prettier.useTabs and prettier.tabWidth in favour of editor.insertSpaces and editor.tabSize

Describe alternatives you've considered
Keeping it as today

Copy link

This issue has been labeled as stale due to inactivity. Reply to keep this issue open.

@github-actions github-actions bot added the Stale label Apr 30, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
Copy link

github-actions bot commented Aug 6, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Aug 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked Please open a new issue and fill out the template instead of commenting. Stale
Projects
None yet
Development

No branches or pull requests

1 participant