Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activeColor token for buttons broken #7134

Open
1 of 4 tasks
WhiskeyBest opened this issue Jan 23, 2025 · 2 comments
Open
1 of 4 tasks

activeColor token for buttons broken #7134

WhiskeyBest opened this issue Jan 23, 2025 · 2 comments
Assignees
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@WhiskeyBest
Copy link

WhiskeyBest commented Jan 23, 2025

Describe the bug

Despite the Aura theme having the following for outlined buttons:

button: {
  colorScheme: {
    light: {
      outlined: {
        contrast: {
          borderColor: 'orange', // <- Works
          activeColor: 'red', // <- Does not work
        },
      },
    },
  },
},

Changes to the activeColor have no affect, and are not defined in the css so far as I can tell.

This not the first broken token I've come across while styling v4 while upgrading from v3, which is the reason I'm finally creating a Github issue for it now. It's been quite frustrating, and really makes me miss working with plain CSS for styling. However I can definitely see the pros of working with this kind of system, so I've been pushing through with css hacks to make things work the way we need it to.

Is this something I should be keeping track as I go (the broken non-affective tokens)? Is there a centralized place where people should be reporting these? Any chance someone could be tasked at primevue with going across all the tokens to make sure they work?

Pull Request Link

n/a

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-raglweh5?file=src%2Fmain.js

Environment

n/a

Vue version

3.5.12

PrimeVue version

4.2.5

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Install the latest Primevue v4
Optional: Latest Apollo Theme

Expected behavior

All currently implemented component tokens be functional and defined in the CSS.

@WhiskeyBest WhiskeyBest added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 23, 2025
@tugcekucukoglu tugcekucukoglu added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 24, 2025
Copy link

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeVue Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

@WhiskeyBest
Copy link
Author

Apologies, it's broken on the outlined severity, the main buttons seem okay. Here is the reproducer as requested:

https://stackblitz.com/edit/primevue-4-vite-issue-template-raglweh5?file=src%2Fmain.js

The original question remains however, I've come across many of broken tokens styling v4 (at least 4 so far). Should I be keeping track of all them and creating separate issues for each?

@tugcekucukoglu tugcekucukoglu added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Resolution: Cannot Replicate Issue could not be replicated by Core Team labels Feb 5, 2025
@tugcekucukoglu tugcekucukoglu added this to the 4.3.1 milestone Feb 5, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Feb 5, 2025
@tugcekucukoglu tugcekucukoglu moved this from Review to Theme in PrimeVue Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Theme
Development

No branches or pull requests

3 participants