Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepInViewPort for Dialog does nothing? #7141

Open
1 of 4 tasks
tim4711 opened this issue Jan 24, 2025 · 2 comments
Open
1 of 4 tasks

keepInViewPort for Dialog does nothing? #7141

tim4711 opened this issue Jan 24, 2025 · 2 comments
Assignees
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@tim4711
Copy link

tim4711 commented Jan 24, 2025

Describe the bug

The primevue dialog component has the prop "keepInViewPort", but it doesn't seem to do anything (if set to false). I cannot observe any difference between the default "basic" app and one in which I set this property to false (and removed modal): still the dialog cannot be pulled from the viewPort.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/nxkqub5k?file=src%2FApp.vue

Environment

Just the "basic" example opened in stackblitz

Vue version

3.2.45

PrimeVue version

4.2.5

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

1.Open the dialog
2. Try to pull it anywhere outside the viewPort.

Expected behavior

Can be pulled outside the viewPort

@tim4711 tim4711 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 24, 2025
@tugcekucukoglu
Copy link
Member

Can you test it in a different environment other than Stackblitz?

@tugcekucukoglu tugcekucukoglu added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 24, 2025
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 24, 2025
@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Jan 24, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Jan 24, 2025
@tim4711
Copy link
Author

tim4711 commented Jan 24, 2025

Well, yes, it also doesn't work in my electron app...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

No branches or pull requests

2 participants