Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to form submit event handlers #7304

Open
4 tasks
xl495 opened this issue Feb 24, 2025 · 0 comments
Open
4 tasks

Add type annotations to form submit event handlers #7304

xl495 opened this issue Feb 24, 2025 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@xl495
Copy link
Contributor

xl495 commented Feb 24, 2025

Describe the bug

When writing form components, I noticed that the FormSubmitEvent type has a values property that's simply Record<string, any>. I want to make it more flexible using a generic type like values: T.

Image

Pull Request Link

#7287

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-v5kacsqm

Environment

this is just a missing type

Vue version

3.5.13

PrimeVue version

4.2.5

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Adding a submit event

Expected behavior

Add generic type T to FormSubmitEvent to represent the values type

@xl495 xl495 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant