clickhandler change

Author: liuliu-dev

packages/react/src/ActionList/Item.tsx

@@ -58,74 +58,17 @@ type LinkItemContainerProps = React.HTMLAttributes<HTMLAnchorElement> &
   }
 
 const LinkItemContainerNoBox = React.forwardRef<HTMLAnchorElement, LinkItemContainerProps>(
-  ({children, onClick, userOnClick, inactiveText, as: Component = 'a', ...rest}, forwardedRef) => {
-    const clickHandler = React.useCallback(
-      (event: React.MouseEvent<HTMLElement>) => {
-        console.log('[LinkItemContainerNoBox] clickHandler called', {
-          hasOnClick: !!onClick,
-          hasUserOnClick: !!userOnClick,
-          event: event.type,
-          target: (event.target as HTMLElement)?.tagName,
-          defaultPrevented: event.defaultPrevented,
-          timestamp: Date.now(),
-        })
-
-        // Check if click is on a button/svg/path (menu trigger) and prevent navigation immediately
-        const targetTag = (event.target as HTMLElement)?.tagName?.toLowerCase()
-        const isMenuTrigger = ['button', 'svg', 'path'].includes(targetTag)
-        console.log('[LinkItemContainerNoBox] Checking target', {
-          targetTag,
-          targetTagRaw: (event.target as HTMLElement)?.tagName,
-          isButton: targetTag === 'button',
-          isSvg: targetTag === 'svg',
-          isPath: targetTag === 'path',
-          willPreventDefault: isMenuTrigger,
-        })
-        if (isMenuTrigger) {
-          console.log(
-            '[LinkItemContainerNoBox] Click on button/svg/path detected, preventing default AND stopping propagation',
-          )
-          event.preventDefault()
-          event.stopPropagation()
-        }
-
-        // Call Item's onClick first (handles selection logic)
-        if (onClick) {
-          console.log('[LinkItemContainerNoBox] Calling Item onClick')
-          onClick(event)
-          console.log('[LinkItemContainerNoBox] After Item onClick', {defaultPrevented: event.defaultPrevented})
-        }
-
-        // Call user's onClick (NavList's onClick) if event not prevented
-        if (userOnClick) {
-          console.log('[LinkItemContainerNoBox] Calling userOnClick (NavList handler)')
-          userOnClick(event as React.MouseEvent<HTMLAnchorElement>)
-          console.log('[LinkItemContainerNoBox] After userOnClick', {defaultPrevented: event.defaultPrevented})
-        }
-      },
-      [onClick, userOnClick],
-    )
+  ({children, onClick, inactiveText, as: Component = 'a', ...rest}, forwardedRef) => {
     if (inactiveText) {
       return (
         <span ref={forwardedRef} {...(rest as React.HTMLAttributes<HTMLSpanElement>)}>
           {children}
         </span>
       )
     }
-    console.log('[LinkItemContainerNoBox] Rendering Link', {
-      Component,
-      hasOnClick: !!onClick,
-      hasUserOnClick: !!userOnClick,
-      restKeys: Object.keys(rest),
-      hasTo: 'to' in rest,
-    })
-    
-    // Remove 'to' prop to prevent React Router from handling navigation
-    // The onClick handlers will manage navigation and menu opening
-    const {to: _, ...restWithoutTo} = rest as typeof rest & {to?: unknown}
-    
+
     return (
-      <Link as={Component} ref={forwardedRef} {...restWithoutTo} onClick={clickHandler}>
+      <Link as={Component} ref={forwardedRef} {...(rest as LinkItemContainerProps)} onClick={onClick}>
         {children}
       </Link>
     )
@@ -243,6 +186,9 @@ const UnwrappedItem = <As extends React.ElementType = 'li'>(
     (event: React.MouseEvent<HTMLElement>) => {
       if (disabled || inactive || loading) return
       onSelect(event, afterSelect)
+      if (isLinkItem && props.onClick) {
+        props.onClick(event as React.MouseEvent<HTMLAnchorElement>)
+      }
     },
     [onSelect, disabled, inactive, afterSelect, loading],
   )
@@ -329,8 +275,6 @@ const UnwrappedItem = <As extends React.ElementType = 'li'>(
       ? {
           ...menuItemProps,
           inactiveText,
-          userOnClick: props.onClick as ((event: React.MouseEvent<HTMLAnchorElement>) => void) | undefined,
-          ref: forwardedRef,
         }
       : !listSemantics && {
           ...menuItemProps,