Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle expired refs #335

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WYGIN
Copy link

@WYGIN WYGIN commented Mar 23, 2024

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • moving res related code that processes response and either returns a res or throws an error are moved to a private function for reusability
  • created a logic that will treat Non-Master Refs as explicitly defined refs
    • 1. and returns an 410 error after several retries to us
    • 2. returns 200 status code if response is successful

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

Resolves:

resolves: #333

@WYGIN WYGIN marked this pull request as draft March 23, 2024 07:46
Signed-off-by: WYGIN <[email protected]>
@WYGIN WYGIN marked this pull request as ready for review March 27, 2024 08:36
Signed-off-by: WYGIN <[email protected]>
@WYGIN
Copy link
Author

WYGIN commented Mar 30, 2024

@angeloashmore can you please take a look at this pr and let me know if any changes required

@stephanebachelier
Copy link

@angeloashmore Could you take a look at this PR? This seems interesting as there are multiple comments in the community forums about this annoying bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically handle expired refs
2 participants