Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarded ref in PrismicNextLink breaks basePath #93

Open
DiemasMichiels opened this issue Mar 25, 2024 · 1 comment
Open

Forwarded ref in PrismicNextLink breaks basePath #93

DiemasMichiels opened this issue Mar 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@DiemasMichiels
Copy link

DiemasMichiels commented Mar 25, 2024

Pages router

Using PrismicNextLink with basePath throws the following hydration error:

Warning: Prop `href` did not match. Server: "/article/my-article" Client: "/home/article/my-article/"

Resulting in an issue where the link can be wrong displayed.
Looking into the issue, I copied the exact PrismicNextLink file from here and tried with that.
Removing the forwarded ref resolved the issue for basePath and the / at the end.

Versions

  • @prismicio/next: v1.5.0
  • next: v14.1.4
  • node: v20.11.1

Steps to reproduce

  • Create a clean Next.js Pages router project
  • Set up some basic routing with the routes in createClient.
  • Add a basePath to next.config.mjs
  • Check console.

What is expected?

The error should not be thrown with or without basePath.

What is actually happening?

An error is thrown, and the path is sometimes incorrect.

@DiemasMichiels DiemasMichiels added the bug Something isn't working label Mar 25, 2024
Copy link

This issue has been labeled as a bug since it was created using the 🚨 Bug Report Template.

Hi there, thank you so much for the report!

Following our Maintenance Process, we will review your bug report and get back to you next Wednesday. To ensure a smooth review of your issue and avoid unnecessary delays, please make sure your issue includes the following:

  • Information about your environment and packages you use (Node.js version, package names and their versions, etc.)
    Feel free to attach a copy of your package.json file.
  • Any troubleshooting steps you already went through
  • A minimal reproduction of the issue, and/or instructions on how to reproduce it

If you have identified the cause of the bug described in your report and know how to fix it, you're more than welcome to open a pull request address it. Check out our quick start guide for a simple contribution process.

If you think your issue is a question (not a bug) and would like quicker support, please close this issue and forward it to an appropriate section on our community forum: https://community.prismic.io

- The Prismic Open-Source Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant