Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: edit approved proposal #628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: edit approved proposal #628

wants to merge 1 commit into from

Conversation

kittybest
Copy link
Collaborator

@kittybest kittybest commented Feb 3, 2025 •
edited
Loading

Description

Allow user to edit Approved proposal (since it's actually submitting "Change" request to the recipient)

  • edit page
  • dump in old data on the edit form
  • submit edit request
  • approve edit request
  • UI display (avoid requests holding same recipientID/index display at the same time)

Additional Notes

(Edit pending Add requests/proposals kind of like submitting new proposal, still need to think how to deactivate the old request since only coordinator can reject old proposals)
(Edit rejected Add requests/proposals should be easier, but that's not in the scope of this PR)

Related issue(s)

close #513

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

@kittybest kittybest added the frontend Frontend related only label Feb 3, 2025
@kittybest kittybest self-assigned this Feb 3, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 1:39pm

@kittybest kittybest force-pushed the feat/edit-approved-proposal branch 2 times, most recently from 53b3101 to e4ccf3d Compare February 4, 2025 08:42
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from e4ccf3d to 6051c7b Compare February 4, 2025 08:58
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from 6051c7b to 9e6ea39 Compare February 4, 2025 09:30
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from 9e6ea39 to f6bd6dd Compare February 4, 2025 15:04
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from f6bd6dd to c3e4859 Compare February 4, 2025 18:39
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from c3e4859 to ac80c4c Compare February 5, 2025 15:49
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from ac80c4c to 698893f Compare February 7, 2025 17:18
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from 698893f to 85dbe57 Compare February 7, 2025 18:44
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from 85dbe57 to 725ce8f Compare February 11, 2025 09:47
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from 725ce8f to 35e89d2 Compare February 11, 2025 10:07
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from 35e89d2 to 1f64314 Compare February 11, 2025 15:46
@kittybest kittybest marked this pull request as ready for review February 11, 2025 15:46
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from 1f64314 to 7a5f8a6 Compare February 12, 2025 17:14
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from 7a5f8a6 to 5b76b51 Compare February 12, 2025 18:14
@kittybest kittybest force-pushed the feat/edit-approved-proposal branch from 5b76b51 to 4b967fe Compare February 13, 2025 23:25
@crisgarner
Copy link
Member

crisgarner commented Feb 13, 2025 •
edited
Loading

Thanks just some comments:

  • When you add edit proposal, the information is empty except for the image, it should be pre-filled with the proposal info.
  • If you want to use the default images then on the preview looks empty, which doesn't allow to submit image
  • The edited proposal is shown as a new one

image

@crisgarner
Copy link
Member

I'm thinking that we should somehow link the old proposal to the edit, as users can get confused
image

@ctrlc03 ctrlc03 force-pushed the feat/edit-approved-proposal branch from 4b967fe to ee959d6 Compare February 14, 2025 13:28
@kittybest
Copy link
Collaborator Author

  • When you add edit proposal, the information is empty except for the image, it should be pre-filled with the proposal info.

I also found it weird that I need to go back and re-click the edit proposal and it would appear, let me check why.

  • If you want to use the default images then on the preview looks empty, which doesn't allow to submit image

I don't find this problem on my local side, could you record a video to this? wanna see the operation steps.

  • The edited proposal is shown as a new one

image

Is the problem here that both old one and edited proposal shown?

@kittybest
Copy link
Collaborator Author

I'm thinking that we should somehow link the old proposal to the edit, as users can get confused image

So do you think we should hide the approved one if there's an edition of the approved proposal?

@kittybest
Copy link
Collaborator Author

@crisgarner
I found there's a problem that all "Add" request having RecipientIndex=0, which causes if you are going to edit the recipient with index=0 would have some bugs. I fix part of it yesterday, let me check this part on the main page again.

@crisgarner
Copy link
Member

I'm thinking that we should somehow link the old proposal to the edit, as users can get confused image

So do you think we should hide the approved one if there's an edition of the approved proposal?

It might be confusing, I would say, for now let's keep it like that

@crisgarner
Copy link
Member

@crisgarner I found there's a problem that all "Add" request having RecipientIndex=0, which causes if you are going to edit the recipient with index=0 would have some bugs. I fix part of it yesterday, let me check this part on the main page again.

I think the issue is still there, the main issue is when you click edit proposal the first time, if you get back or try to edit again, the info is loaded. will share video by DM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 Awaiting requested review from ctrlc03 ctrlc03 is a code owner

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

@NicoSerranoP NicoSerranoP Awaiting requested review from NicoSerranoP NicoSerranoP is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kittybest kittybest

Labels
frontend Frontend related only
Projects
MACI Platform
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(frontend/contract): editing an application before application period ends
2 participants
@kittybest @crisgarner