Skip to content

Commit 91f8ae1

Browse files
authored
feat: typescript template improvement (#120)
This update improves the TypeScript template: * Common options in `tsconfig.json` now include a short description of what each option does and their possible values. * The `dev` script now works as intended. The script will run your application and restart the process when changes are made to the app source files.
1 parent 06a6a1c commit 91f8ae1

File tree

4 files changed

+84
-26
lines changed

4 files changed

+84
-26
lines changed

templates/basic-ts/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@
88
# Install dependencies
99
npm install
1010

11-
# Run typescript
12-
npm run build
11+
# Run with hot reload
12+
npm run build:watch
1313

14-
# Run the bot
15-
npm start
14+
# Compile and run
15+
npm run build
16+
npm run start
1617
```
1718

1819
## Contributing

templates/basic-ts/nodemon.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"signal": "SIGINT",
3+
"watch": ["lib", ".env"],
4+
"delay": "2000",
5+
"verbose": false,
6+
"exec": ["npm run start"]
7+
}

templates/basic-ts/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
"probot-app"
1515
],
1616
"scripts": {
17-
"build": "tsc -p tsconfig.json",
18-
"dev": "nodemon --exec \"npm start\"",
17+
"build": "tsc",
18+
"build:watch": "tsc && (tsc -w --preserveWatchOutput & nodemon)",
19+
"dev": "npm run build:watch",
1920
"start": "probot run ./lib/index.js",
2021
"lint": "standard **/*.ts --fix",
2122
"test": "jest && standard **/*.ts",

templates/basic-ts/tsconfig.json

Lines changed: 69 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,74 @@
11
{
22
"compilerOptions": {
3-
"allowJs": false,
4-
"lib": ["es2015", "es2017"],
5-
"module": "commonjs",
6-
"moduleResolution": "node",
7-
"target": "es5",
8-
"noImplicitReturns": true,
9-
"noFallthroughCasesInSwitch": true,
10-
"noUnusedLocals": false,
11-
"pretty": true,
12-
"strict": true,
13-
"sourceMap": true,
14-
"outDir": "./lib",
15-
"skipLibCheck": true,
16-
"noImplicitAny": true,
17-
"esModuleInterop": true,
18-
"declaration": true,
19-
"resolveJsonModule": true
3+
/* Basic Options */
4+
"incremental": true /* Enable incremental compilation */,
5+
"target": "es5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */,
6+
"module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */,
7+
"lib": [
8+
"es2015",
9+
"es2017"
10+
] /* Specify library files to be included in the compilation. */,
11+
"allowJs": true /* Allow javascript files to be compiled. */,
12+
"checkJs": true /* Report errors in .js files. */,
13+
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
14+
"declaration": true /* Generates corresponding '.d.ts' file. */,
15+
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
16+
"sourceMap": true /* Generates corresponding '.map' file. */,
17+
// "outFile": "./", /* Concatenate and emit output to single file. */
18+
"outDir": "./lib" /* Redirect output structure to the directory. */,
19+
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
20+
// "composite": true, /* Enable project compilation */
21+
// "tsBuildInfoFile": "./" /* Specify file to store incremental compilation information */,
22+
// "removeComments": true, /* Do not emit comments to output. */
23+
// "noEmit": true, /* Do not emit outputs. */
24+
// "importHelpers": true, /* Import emit helpers from 'tslib'. */
25+
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
26+
// "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
27+
28+
/* Strict Type-Checking Options */
29+
"strict": true /* Enable all strict type-checking options. */,
30+
// "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */
31+
// "strictNullChecks": true, /* Enable strict null checks. */
32+
// "strictFunctionTypes": true, /* Enable strict checking of function types. */
33+
// "strictBindCallApply": true, /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
34+
// "strictPropertyInitialization": true, /* Enable strict checking of property initialization in classes. */
35+
// "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */
36+
// "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
37+
38+
/* Additional Checks */
39+
"noUnusedLocals": true /* Report errors on unused locals. */,
40+
"noUnusedParameters": true /* Report errors on unused parameters. */,
41+
"noImplicitReturns": true /* Report error when not all code paths in function return a value. */,
42+
"noFallthroughCasesInSwitch": true /* Report errors for fallthrough cases in switch statement. */,
43+
44+
/* Module Resolution Options */
45+
"moduleResolution": "node" /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */,
46+
// "baseUrl": "./src" /* Base directory to resolve non-absolute module names. */,
47+
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
48+
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */
49+
// "typeRoots": [], /* List of folders to include type definitions from. */
50+
// "types": [], /* Type declaration files to be included in compilation. */
51+
// "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
52+
"esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */,
53+
// "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */
54+
// "allowUmdGlobalAccess": true, /* Allow accessing UMD globals from modules. */
55+
56+
/* Source Map Options */
57+
// "sourceRoot": "", /* Specify the location where debugger should locate TypeScript files instead of source locations. */
58+
// "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */
59+
// "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
60+
// "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
61+
62+
/* Experimental Options */
63+
// "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */
64+
// "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */
65+
66+
/* Advanced Options */
67+
"forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */,
68+
"resolveJsonModule": true,
69+
"pretty": false,
70+
"skipLibCheck": true
2071
},
21-
"include": [
22-
"src/**/*"
23-
],
72+
"include": ["src/"],
2473
"compileOnSave": false
2574
}

0 commit comments

Comments
 (0)