Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Duplicate method settings()" when using smooth() in setup() #861

Closed
Gargaj opened this issue Nov 27, 2024 · 13 comments
Closed

"Duplicate method settings()" when using smooth() in setup() #861

Gargaj opened this issue Nov 27, 2024 · 13 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists help wanted Extra attention is needed

Comments

@Gargaj
Copy link

Gargaj commented Nov 27, 2024

Most appropriate sub-area of Processing 4?

Core/Environment/Rendering

Processing version

4.3.1

Operating system

Windows 11

Steps to reproduce this

Creating the following sketch produces the error Duplicate method settings() even though there's only one settings() function; the solution is to remove the smooth() call, which makes the error go away, even though the error message doesn't imply that's the solution.

snippet

void settings()
{
}

void setup()
{
  smooth();
}

Additional context

image

@Gargaj Gargaj added the bug Something isn't working label Nov 27, 2024
@plopez01
Copy link
Contributor

Hello and thanks for posting the issue, I have been able to reproduce this. I think it's the same as #823

@Gargaj
Copy link
Author

Gargaj commented Nov 27, 2024

Argh, I searched for "duplicate method settings" on both here and Google :/

@SableRaf SableRaf added the duplicate This issue or pull request already exists label Nov 27, 2024
@Stefterv Stefterv added the help wanted Extra attention is needed label Jan 14, 2025
@Whiteeth-princess
Copy link

thx

@SushantBansal-tech
Copy link

SushantBansal-tech commented Mar 17, 2025

@Stefterv and @SableRaf Can you please assign this issue to me .

@SableRaf
Copy link
Collaborator

Hi @SushantBansal-tech. Just a quick note: we usually assign one issue at a time per new contributor to help keep things manageable. Thanks for understanding! Once you're done with #898, feel free to comment here again and we’ll be happy to assign this one to you.

@SushantBansal-tech
Copy link

@SableRaf Actually I have comment here before this issue #898..

@SableRaf
Copy link
Collaborator

Hi @SushantBansal-tech. Not a problem! We're currently focusing on the other issue, so let's keep our attention there for now. Once that's sorted, we can come back to this one :)

@SushantBansal-tech
Copy link

@SableRaf I'd like to work on this issue while my previous PR is still in the review process. I'm also interested in submitting a proposal for the project as well . Would that be alright with you?"

@SableRaf
Copy link
Collaborator

SableRaf commented Apr 1, 2025

Hi @SushantBansal-tech, thanks for your enthusiasm!

For new contributors, we usually recommend sticking to one issue at a time to keep things both manageable and fair. Since you’re still working on #898, I’d suggest focusing on that for now. Thanks for your patience while we review it.

Based on your contributions so far, I think this issue might be a bit too complex at this stage, as it requires a deeper understanding of Processing’s core. Once you’ve completed #898 and gained more experience, feel free to check out issues labeled “good first issue” for more opportunities to contribute.

Thanks for your commitment!

@SushantBansal-tech
Copy link

SushantBansal-tech commented Apr 1, 2025

@SableRaf So can you please review it #898 as i also want to submit the proposal for GSOC as well and do not have any PRs right now . for the proposal I have also collected some valuable approaches
Here is he PR ; #1020

@SableRaf
Copy link
Collaborator

SableRaf commented Apr 1, 2025

Hi @SushantBansal-tech,

As a reminder, there’s no requirement to have a PR merged for your project to be accepted in GSoC. As mentioned by @ksen0 on the GSoC Discourse thread:

Making lots of PRs might not actually be as helpful to your proposal as taking the time to research and develop a strong technical concept and execution plan.

I really appreciate your enthusiasm and willingness to contribute! Just keep in mind that taking the time to develop a thoughtful proposal and engaging constructively with the community will make a stronger impression than just having an accepted PR.

Showing that you’re mindful of the team’s limited capacity when seeking feedback will also be much appreciated 💙

I recommend attentively reading Kit’s posts on the Discourse thread; they’re highlighted in yellow and contain important guidance for preparing a strong application.

Here’s a relevant section from one of Kit’s messages. I encourage you to read it carefully, as it contains valuable insights:

Selection will be taking the application as a whole. The proposal matters a lot, and a good proposal is one that showcases your idea, and reflects that you’ve done some research (for example, understanding some relevant GitHub issues or commits to find out what specific decisions have been made in the past and why, and what are the concrete challenges of implementing your idea in specific.)

In addition to the proposal, we will consider all forms of contribution, as PF follows the all-contributors spec for both p5.js and Processing 4. The means that you can mention as contribution not only PRs, but also blog posts, events you might have hosted in the past, etc. Contribution also includes constructive participation in our online community spaces - that means GitHub issues as well as here, in this thread! Jumping in and helping to answer newcomers’ questions more quickly than I get to it is 💯 a contribution in the question category!

In the application, the purpose of contribution, like the purpose of research, is to show that you’ve gotten a little familiar with the technologies you’re proposing to work with and that you’re comfortable with the code of conduct and contributor guidelines that applies to the project you’re proposing about.

Both these considerations (technical understanding in the scope of your project and community values and process alignment) are very important, and both are necessary. Neither requires making PRs! You’re welcome to be creative in how you’re approaching showing each of these in the proposal.

@Gargaj
Copy link
Author

Gargaj commented Apr 1, 2025

I looked into it briefly (just by reading the repo) and I suspect it has something to do with https://github.com/processing/processing4/blob/main/java/src/processing/mode/java/preproc/PdeParseTreeListener.java#L372-L380

@SableRaf
Copy link
Collaborator

SableRaf commented Apr 1, 2025

Thanks @Gargaj. I've added your comment to the original issue. I'll be closing this one as duplicate. Let's continue this discussion in #823 💙 Thanks for your sleuthing!

@SableRaf SableRaf closed this as completed Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants