Fix PROCRASTINATE_VERBOSE vs PROCRASTINATE_VERBOSITY inconsistency #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes procrastinate-org#1405 The CLI code was using PROCRASTINATE_VERBOSE as the environment variable, while the documentation incorrectly specified PROCRASTINATE_VERBOSITY. Additionally, the documentation claimed to support 3 log levels (warning, info, debug), but the code only supports 2 levels (info at 0, debug at 1+). Changes: - Fixed documentation to use PROCRASTINATE_VERBOSE (matching the code) - Command line flags (-v, -vv) now properly override environment variables instead of adding to them - Added new --log-level option (mutually exclusive with -v) that allows explicit control over all log levels: debug, info, warning, error, critical - Added PROCRASTINATE_LOG_LEVEL environment variable support - Updated documentation to reflect actual behavior and document new options - Updated help text to clearly show verbosity levels: 0=info, 1+=debug - Added comprehensive tests to verify: * PROCRASTINATE_VERBOSE environment variable works correctly * Command line flags override (not add to) environment variables * --log-level option works with all log levels * --log-level and -v are mutually exclusive * PROCRASTINATE_LOG_LEVEL environment variable works correctly All existing tests pass, and new tests confirm all functionality works as expected.
for more information, see https://pre-commit.ci
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Verifies that when configure_logging() is called with no arguments (no verbosity or log_level specified), it defaults to logging.INFO level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1405
The CLI code was using PROCRASTINATE_VERBOSE as the environment variable, while the documentation incorrectly specified PROCRASTINATE_VERBOSITY. Additionally, the documentation claimed to support 3 log levels (warning, info, debug), but the code only supports 2 levels (info at 0, debug at 1+).
Changes:
Successful PR Checklist:
PR label(s):