Skip to content

Commit 014b5dd

Browse files
authored
minor edits to apidoc comments (#349)
1 parent 61857bc commit 014b5dd

File tree

3 files changed

+20
-19
lines changed

3 files changed

+20
-19
lines changed

Diff for: api/v1beta2/appwrapper_types.go

+7-6
Original file line numberDiff line numberDiff line change
@@ -42,27 +42,27 @@ type AppWrapperComponent struct {
4242
//+optional
4343
Annotations map[string]string `json:"annotations,omitempty"`
4444

45-
// DeclaredPodSets for the Component (optional for known PodCreating GVKs)
45+
// DeclaredPodSets for the Component (optional for known GVKs whose PodSets can be automatically inferred)
4646
//+optional
4747
DeclaredPodSets []AppWrapperPodSet `json:"podSets,omitempty"`
4848

4949
// PodSetInfos assigned to the Component's PodSets by Kueue
5050
//+optional
5151
PodSetInfos []AppWrapperPodSetInfo `json:"podSetInfos,omitempty"`
5252

53+
// Template defines the Kubernetes resource for the Component
5354
// +kubebuilder:pruning:PreserveUnknownFields
5455
// +kubebuilder:validation:EmbeddedResource
55-
// Template defines the Kubernetes resource for the Component
5656
Template runtime.RawExtension `json:"template"`
5757
}
5858

59-
// AppWrapperPodSet describes an homogeneous set of pods
59+
// AppWrapperPodSet describes a homogeneous set of pods
6060
type AppWrapperPodSet struct {
6161
// Replicas is the number of pods in this PodSet
6262
//+optional
6363
Replicas *int32 `json:"replicas,omitempty"`
6464

65-
// Path is the path Component.Template to the PodTemplateSpec for this PodSet
65+
// Path is the path within Component.Template to the PodTemplateSpec for this PodSet
6666
Path string `json:"path"`
6767

6868
// Annotations is an unstructured key value map that may be used to store and retrieve
@@ -90,7 +90,7 @@ type AppWrapperPodSetInfo struct {
9090
SchedulingGates []corev1.PodSchedulingGate `json:"schedulingGates,omitempty"`
9191
}
9292

93-
// AppWrapperStatus defines the observed state of the appwrapper
93+
// AppWrapperStatus defines the observed state of the AppWrapper
9494
type AppWrapperStatus struct {
9595
// Phase of the AppWrapper object
9696
//+optional
@@ -149,7 +149,7 @@ type AppWrapperComponentStatus struct {
149149
Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"`
150150
}
151151

152-
// AppWrapperPhase is the phase of the appwrapper
152+
// AppWrapperPhase enumerates the valid Phases of an AppWrapper
153153
type AppWrapperPhase string
154154

155155
const (
@@ -164,6 +164,7 @@ const (
164164
AppWrapperTerminating AppWrapperPhase = "Terminating"
165165
)
166166

167+
// AppWrapperCondition enumerates the Condition Types that may appear in AppWrapper status
167168
type AppWrapperCondition string
168169

169170
const (

Diff for: config/crd/bases/workload.codeflare.dev_appwrappers.yaml

+8-8
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ spec:
150150
type: array
151151
podSets:
152152
description: DeclaredPodSets for the Component (optional for
153-
known PodCreating GVKs)
153+
known GVKs whose PodSets can be automatically inferred)
154154
items:
155-
description: AppWrapperPodSet describes an homogeneous set
155+
description: AppWrapperPodSet describes a homogeneous set
156156
of pods
157157
properties:
158158
annotations:
@@ -163,8 +163,8 @@ spec:
163163
arbitrary metadata about the PodSet to customize its treatment by the AppWrapper controller.
164164
type: object
165165
path:
166-
description: Path is the path Component.Template to the
167-
PodTemplateSpec for this PodSet
166+
description: Path is the path within Component.Template
167+
to the PodTemplateSpec for this PodSet
168168
type: string
169169
replicas:
170170
description: Replicas is the number of pods in this PodSet
@@ -195,7 +195,7 @@ spec:
195195
- components
196196
type: object
197197
status:
198-
description: AppWrapperStatus defines the observed state of the appwrapper
198+
description: AppWrapperStatus defines the observed state of the AppWrapper
199199
properties:
200200
componentStatus:
201201
description: ComponentStatus parallels the Components array in the
@@ -284,7 +284,7 @@ spec:
284284
(either from AppWrapperComponent.DeclaredPodSets or inferred
285285
by the controller)
286286
items:
287-
description: AppWrapperPodSet describes an homogeneous set
287+
description: AppWrapperPodSet describes a homogeneous set
288288
of pods
289289
properties:
290290
annotations:
@@ -295,8 +295,8 @@ spec:
295295
arbitrary metadata about the PodSet to customize its treatment by the AppWrapper controller.
296296
type: object
297297
path:
298-
description: Path is the path Component.Template to the
299-
PodTemplateSpec for this PodSet
298+
description: Path is the path within Component.Template
299+
to the PodTemplateSpec for this PodSet
300300
type: string
301301
replicas:
302302
description: Replicas is the number of pods in this PodSet

Diff for: site/_pages/appwrapper.v1beta2.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ arbitrary metadata about the Component to customize its treatment by the AppWrap
7878
<a href="#workload-codeflare-dev-v1beta2-AppWrapperPodSet"><code>[]AppWrapperPodSet</code></a>
7979
</td>
8080
<td>
81-
<p>DeclaredPodSets for the Component (optional for known PodCreating GVKs)</p>
81+
<p>DeclaredPodSets for the Component (optional for known GVKs whose PodSets can be automatically inferred)</p>
8282
</td>
8383
</tr>
8484
<tr><td><code>podSetInfos</code><br/>
@@ -165,7 +165,7 @@ arbitrary metadata about the Component to customize its treatment by the AppWrap
165165
- [AppWrapperStatus](#workload-codeflare-dev-v1beta2-AppWrapperStatus)
166166

167167

168-
<p>AppWrapperPhase is the phase of the appwrapper</p>
168+
<p>AppWrapperPhase enumerates the valid Phases of an AppWrapper</p>
169169

170170

171171

@@ -180,7 +180,7 @@ arbitrary metadata about the Component to customize its treatment by the AppWrap
180180
- [AppWrapperComponentStatus](#workload-codeflare-dev-v1beta2-AppWrapperComponentStatus)
181181

182182

183-
<p>AppWrapperPodSet describes an homogeneous set of pods</p>
183+
<p>AppWrapperPodSet describes a homogeneous set of pods</p>
184184

185185

186186
<table class="table">
@@ -199,7 +199,7 @@ arbitrary metadata about the Component to customize its treatment by the AppWrap
199199
<code>string</code>
200200
</td>
201201
<td>
202-
<p>Path is the path Component.Template to the PodTemplateSpec for this PodSet</p>
202+
<p>Path is the path within Component.Template to the PodTemplateSpec for this PodSet</p>
203203
</td>
204204
</tr>
205205
<tr><td><code>annotations</code><br/>
@@ -315,7 +315,7 @@ arbitrary metadata about the PodSet to customize its treatment by the AppWrapper
315315
- [AppWrapper](#workload-codeflare-dev-v1beta2-AppWrapper)
316316

317317

318-
<p>AppWrapperStatus defines the observed state of the appwrapper</p>
318+
<p>AppWrapperStatus defines the observed state of the AppWrapper</p>
319319

320320

321321
<table class="table">

0 commit comments

Comments
 (0)