Skip to content

[quality] dakota#743 finupdate cc-panel adds C code with no test coverageΒ #809

@kubestellar-hive

Description

@kubestellar-hive
Dakota πŸ¦–  Β·  issue pipeline
─────────────────────────────────────────────────
  β–Ά  filed      report received
  Β·  approved   β€”
  Β·  queued     β€”
  Β·  claimed    β€”
  Β·  done       β€”
─────────────────────────────────────────────────
  report:       missing     Β·  confirms: 0
  area:         β€”         Β·  priority: β€”
  next action:  same bug? ujust confirm 809

---## Finding

PR #743 (feat(cc-panel): scaffold finupdate Updates panel) adds ~418 lines of new code including:

  • cc-updates-panel.c / .h β€” GTK4 panel implementation
  • meson.build β€” build system integration
  • finupdate.bst β€” BuildStream element
  • Two gnome-build-meta patches

None of this has any test coverage. The C code implements UI logic for system updates β€” a user-facing critical path.

Recommendation

  1. Build validation test: Add a CI check that the BST element parses correctly (even if it can't fully build without deps). At minimum, validate the element YAML syntax.
  2. Meson build smoke test: Verify meson.build can configure successfully with mocked dependencies.
  3. Panel source validation: Add basic compilation check for the C code against GTK4 headers (can be done in a container).

Since the element is marked DRAFT with TODOs, at minimum the PR should include a validation plan or CI workflow that will run once the remaining dependencies are wired.

Priority

  • Impact: high β€” user-facing system update panel with no safety net
  • Effort: medium

Filed by quality agent (hold-gated mode)

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-triageNeeds human review β€” set kind, priority, and area.status/discussingStructured issue flow in progress; not ready for the agent queue yet.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions