fix(ci): exclude promotion PR from pr-autoupdate#971
Conversation
auto/promote-testing-to-main is always rebuilt fresh by promote-testing-to-main.yml. When pr-autoupdate does a merge commit onto the squash branch it changes the tree, defeats the tree-identity check in reusable-promote-squash.yml, triggers a force-push on the next promote run, and dismisses any pending maintainer approval. Exclude the branch so the promote workflow stays the sole owner of that branch. Also flipped dismiss_stale_reviews to false in branch protection via API so a valid approval survives the nightly squash rebuild when the tree content is identical. Assisted-by: Claude Sonnet 4.6 via GitHub Copilot
|
Thanks for the PR! A maintainer will review it. While you wait, make sure these pass locally: just validate # element graph check
just build default # build the image
just boot-test # confirm the desktop boots (exits 0 = pass)
just lint # bootc container lintIf this PR fixes a bug, add verify steps to the linked issue so users can confirm the fix on their hardware after the next nightly ships: ```verify
ujust <something> # what users should run to confirm the fix
``` |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesPR Auto-Update Exclusion for Promote Branch
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
pr-autoupdate.ymlwas runninggh pr update-branchonauto/promote-testing-to-mainwhenever main advanced. This created a merge commit on the squash branch which:reusable-promote-squash.ymldismiss_stale_reviews: true)Result: approvals could never survive to merge. The PR regenerated itself in a loop.
Fix
auto/promote-testing-to-mainfrompr-autoupdate.yml— the promote workflow is the sole owner of that branch and always rebuilds from freshorigin/maindismiss_stale_reviewstofalsein branch protection via API — a valid approval now survives the nightly squash rebuild when tree content is identicalTesting
Branch protection change is live. The next promote run + approval will verify the fix.
Summary by CodeRabbit