Skip to content

feat(document-validity): yield validation loading state from component #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(document-validity): yield validation loading state from component #2988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/form/addon/components/document-validity.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{{#if @validateOnEnter}}
<div {{in-viewport onEnter=this.validate}}>
{{yield this.isValid this.validate}}
{{yield this.isValid this.validate this.isValidating}}
</div>
{{else}}
{{yield this.isValid this.validate}}
{{yield this.isValid this.validate this.isValidating}}
{{/if}}
21 changes: 13 additions & 8 deletions packages/form/addon/components/document-validity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { action } from "@ember/object";
import Component from "@glimmer/component";
import { restartableTask } from "ember-concurrency";
import { task } from "ember-concurrency";
import { cached } from "tracked-toolbox";

/**
Expand Down Expand Up @@ -39,8 +39,11 @@ export default class DocumentValidity extends Component {
.every((f) => f.isValid);
}

@restartableTask
*_validate() {
get isValidating() {
return this._validate.isRunning;
}

_validate = task({ restartable: true }, async () => {
const saveTasks = this.args.document.fields
.flatMap((field) => [
...[...(field._components ?? [])].map((c) => c.save.last),
Expand All @@ -50,11 +53,13 @@ export default class DocumentValidity extends Component {

// Wait until all currently running save tasks in the UI and in the field
// itself are finished
yield Promise.all(saveTasks);
await Promise.all(saveTasks);

for (const field of this.args.document.fields) {
yield field.validate.linked().perform();
}
await Promise.all(
this.args.document.fields.map(
async (field) => await field.validate.linked().perform(),
),
);

if (this.isValid) {
this.args.onValid?.();
Expand All @@ -63,7 +68,7 @@ export default class DocumentValidity extends Component {
}

return this.isValid;
}
});

@action
validate() {
Expand Down
Loading