Repository navigation
Make FluentMessage::attributes() return ExactSizeIterator #263
Description
It may be an unusual way of using attributes, but we plan to use them to implement message variation, for example, for NPCs speech in the game.
npc-speech-adventurous =
.1 = I hope to make my own glider someday.
.2 = I'd like to go spelunking in a cave when I'm stronger.And we would like to choose a random message.
To do that we have multiple options.
- Collect everything into Vec, which seems like redundancy when attributes are already Vec internally.
- Expose the vector directly, which might harm incapsulation a bit
- Make .attributes() return ExactSizeIterator, so that we can get the length of it, and then using
.skip()taking needed element.
Activity
[-][Feature Request] Make FluentMessage::Atributes return ExactSizeIterator[/-][+][Feature Request] Make FluentMessage::attributes() return ExactSizeIterator[/+]juliancoffee commentedon Aug 7, 2022
@zbraniecki do you foresee any problems with this?
zbraniecki commentedon Aug 7, 2022
It may be a case of an explicit antipattern in Fluent - https://github.com/projectfluent/fluent/wiki/Good-Practices-for-Developers#prefer-separate-messages-over-variants-for-ui-logic
If those are actually variants of the same message, as in same message but varied by tone etc. then maybe it's ok.
But generally, I'd advise you to create them as separate messages and store a Vec of message ids in your code to select from.
juliancoffee commentedon Aug 25, 2022
Well, reading this link, I would say "yes" to both.
Otherwise, we wouldn't have them random :)
juliancoffee commentedon Aug 25, 2022
Also to add to this, having it random makes it possible to have a different number of variants in different languages.
[-][Feature Request] Make FluentMessage::attributes() return ExactSizeIterator[/-][+]Make FluentMessage::attributes() return ExactSizeIterator[/+]