Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Abort scenarios gracefully #8

Open
ajantha-bhat opened this issue Apr 17, 2023 · 1 comment
Open

Handle Abort scenarios gracefully #8

ajantha-bhat opened this issue Apr 17, 2023 · 1 comment

Comments

@ajantha-bhat
Copy link
Contributor

When the user kills the process or another hard failure occurs, the "result files" will not be populated and the user "left in the dark"

Need to fix this.

Currently in this case, users has to do listTables in target catalog to see what tables are newly registered.
@ajantha-bhat ajantha-bhat mentioned this issue Apr 17, 2023
Merged
@ajantha-bhat
Copy link
Contributor Author

After thinking more about this, the user can still refer to the catalog_migration.log file to get the successfully migrated table names. So, they are not really left in dark.

I will also add a Runtime.getRuntime().addShutdownHook(xx) to dump the current lists (from catalogMigrator.result) incase of user abort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajantha-bhat