-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Catalog] write.data.path
& write.metadata.path
- forbid or respect?
#8859
Comments
As per our discussion on Zulip and our call, we would like to see specifying paths supported, both on a table as well as a namespace/schema level. Our particular use case is through Trino, where a With the Nessie REST catalog, tables get stored in the warehouse's configured bucket in a We do not need support for changing the data and metadata paths specifically, only the overall base location of a table. |
#9170 adds some better support for Trino that eliminates the need to manually specify the |
@marvin-roesch with #9170 Nessie still controls the |
@marvin-roesch is Nessie 0.95.0 working for you? |
@snazy Unfortunately we haven't had a chance yet to try out the newest version as other projects took precedence 😅 We're planning for a Trino and Nessie upgrade by end of this week, will report after that! |
@snazy Just looking at the changes from that MR, I still don't think we'll be able to use Nessie with the Iceberg REST catalog just yet while maintaining our current S3 setup, but please correct me if I'm wrong. We do explicitly set the Having new tables created in the warehouse's default bucket isn't bad, but it's a little confusing for us and our users to have to go looking for a table's data in an unexpected location. Are there plans to support this use case? Otherwise we would make an effort to migrate everything to a single bucket for our setup. |
Hm - yea - a different bucket wouldn't work yet. But migrating Iceberg tables is a huge effort (literally rewrite everything). Can you check whether everything else works for you? |
I'll run a few tests later this week to verify everything else is working for us and report back 👍 Thanks for the follow-up, that'd be ideal for us! |
NP, we're preparing a "bigger" release at the moment. |
The
write.data.path
andwrite.metadata.path
table properties instruct clients to use that location for write operations.write.data.path
overrides the table-metadatalocation
- seeorg.apache.iceberg.LocationProviders.DefaultLocationProvider#dataLocation
.write.metadata.path
overrides the table-metadatalocation + "/metadata"
default.We should either forbid setting this property or consider this as a base location.
Other already deprecated properties:
write.folder-storage.path
andwrite.object-storage.path
.See
org.apache.iceberg.TableProperties
.I suspect we have to respect existing values (for "imported" table-metadata) and prevent setting this property, but allow removing this property.
The text was updated successfully, but these errors were encountered: