fix(prometheus): use ansible_facts for fqdn - #870
Merged
SuperQ merged 1 commit intoAug 24, 2026
Merged
Conversation
Contributor
Docs Build 📝Thank you for contributing!✨ This PR has been merged and the docs are now incorporated into |
Contributor
Author
|
Any idea what's going on with this second set of integration test failures here? I'm investigating but it doesn't seem related to my change. |
Contributor
Author
|
CI failures diagnosis: #869 (comment) |
Signed-off-by: Will Buckner <1458615+willbuckner@users.noreply.github.com>
willbuckner
force-pushed
the
fix/prometheus-injected-fqdn-fact
branch
from
August 24, 2026 07:47
d7a2411 to
b63c191
Compare
Contributor
Author
|
@SuperQ this one is rebased on top of your CI fixes and is ready to go as well :) Thanks! |
SuperQ
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ansible_fqdnreferences withansible_facts['fqdn'].ansible_host,inventory_hostname, andlocalhostfallbacks.Motivation
This fixes a deprecation warning I was seeing on my own Ansible deployments. The default behavior of injecting facts as top-level variables is deprecated and will be removed in ansible-core 2.24.
Reading
fqdndirectly fromansible_factsavoids the deprecation warning and works wheninject_facts_as_varsis disabled.This is a follow-up to #845.
Validation
ansible-lintandyamllintpassed with zero failures or warnings.git diff --checkpassed.