Add HTTPS Certificate to prombench.prometheus.io#777
Merged
kakkoyun merged 3 commits intoFeb 20, 2025
Merged
Conversation
Signed-off-by: Vandit Singh <vanditsinghkv@gmail.com>
Contributor
Author
|
Does this PR require some changes? gentle ping @bboreham |
kakkoyun
reviewed
Nov 28, 2024
Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Vandit Singh <107131545+Vandit1604@users.noreply.github.com>
kakkoyun
approved these changes
Feb 20, 2025
SuperQ
reviewed
Feb 20, 2025
Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Vandit Singh <107131545+Vandit1604@users.noreply.github.com>
SuperQ
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #724
This PR aims to add an HTTPS certificate for
prombench.prometheus.iousing Cert-Manager and Let's Encrypt. Testing the setup locally has proven challenging. Here’s a summary of the modifications and approaches tried so far:Servicetype toNodePortfromLoadBalancerfor easier local access.Servicetype toClusterIPwith Ingress managing external access.prombench-prometheus-tlssecret for HTTPS./etc/hoststo mapprombench.prometheus.ioto127.0.0.1but it worked when I mapped it to Node IP and add the Host in the header when testing to/etc/hosts, but the challenge does not get solved automatically with the manifest setup.I’d appreciate any guidance on how to test this locally. The Issue was because of DNS since after mapping in
/etc/hostsI was able to solve the challenge(Tested via curl)If there's a better way to test this locally. Please let me know.
Thank you!