Skip to content

Commit 13bcf1d

Browse files
remigiusz-antczakRemigiusz Antczakclaude
authored
feat(skill): 1.104.0 — wave 25 name the threat-modeling method + coverage lens (#275) (#283)
The highest round-2 gap after an idea-critic pass, which revised the sequence: ship #275 as a coverage lens now (low-risk, continues the #265 pattern), the #267 precision/recall instrument next (corpus-ready from this repo's own defects), and deprioritize #276 (AI-governance) as the lowest review-action-density and most date-sensitive. #275 — security-appsec.md A06 (Insecure Design) already asks "is there a threat model?"; this names WHICH method fits — STRIDE (per element), PASTA (business impact), attack trees (one goal), LINDDUN (privacy, STRIDE's privacy counterpart), MAESTRO (agentic AI, complementary to the OWASP ASI / MITRE ATLAS catalogs) — and adds the coverage lens: a change that introduces a trust boundary / principal / state transition the existing model never considered is a finding (the model went stale relative to the diff), and an agentic surface with no agent-specific model is the common miss. A reciprocal MAESTRO pointer added in security-ai-agents.md. Maturity frames (SSDF/SAMM/BSIMM) named, not scored. Built as a lens with a discriminating eval, not a framework catalog (the idea-critic's constraint). Lockstep version bump (deep-code-review, agentic-delivery, idea-critic, plugin) to 1.104.0; one new eval (dcr 107); SHA256SUMS regenerated. Independent dogfood review: FIX-FIRST -> 2 fixed pre-merge (a Medium: MAESTRO provenance overstated as "behind" the OWASP ASI/MITRE ATLAS catalogs — reworded to "complementary", version detail dropped so no standards-index citation is owed; a Low: LINDDUN cross-ref pointed at privacy-by-design.md, which never mentions it — attribution dropped, LINDDUN stated as STRIDE's privacy counterpart). Tests: 67/67 CI gates pass; evals.json valid; routing clean; install.sh syntax OK; privacy scan clean. Co-authored-by: Remigiusz Antczak <remigiusz@antczak.io> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 0ab915f commit 13bcf1d

9 files changed

Lines changed: 56 additions & 11 deletions

File tree

‎.claude-plugin/plugin.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "deep-code-review",
33
"description": "Perun — bring the thunder to your codebase. A portable, evidence-grounded quality bar for building with AI agents: the flagship deep-code-review skill (default install is review-only), plus opt-in overlays — gated delivery, an idea critic, a suite conductor, and stage-aware product, growth, positioning, business-ops, and output-safety specialists.",
44
"skills": "./.claude/skills",
5-
"version": "1.103.0",
5+
"version": "1.104.0",
66
"author": {
77
"name": "deep-code-review contributors"
88
},
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.103.0
1+
1.104.0
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.103.0
1+
1.104.0

‎.claude/skills/deep-code-review/evals/evals.json‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1128,6 +1128,17 @@
11281128
"Maps all six severities to the de-facto markers, Medium -> Important (a real defect, not a Nit), Low/Nit -> Nit, pre-existing -> Pre-existing",
11291129
"Keeps the idempotent-additive imprint discipline and the rule->bad->good->reasoning format"
11301130
]
1131+
},
1132+
{
1133+
"id": "threat-model-coverage-names-the-method-and-flags-a-stale-model",
1134+
"prompt": "A PR adds an autonomous agent that can call external tools and spend from a budget. The team says 'we already did a STRIDE threat model of the app last year.' Is that covered, and what do we check?",
1135+
"expected_output": "Not covered -- name the method that fits and check coverage, not ceremony. A year-old STRIDE model of the app does not model an AUTONOMOUS AGENT with tool-calling and spend authority: that introduces new trust boundaries, a new principal (the agent acting on a user's behalf), and new state transitions the old model never considered, so the model is stale relative to the diff -- a finding. The fitting method here is MAESTRO (the agentic-AI threat-modeling method, complementary to the OWASP ASI / MITRE ATLAS catalogs), not general STRIDE; LINDDUN if privacy threats are in scope; PASTA if threats must tie to business impact; attack trees to decompose one attacker goal. The review lens is: does the change introduce a trust boundary / principal / transition the existing model didn't cover (here, yes), and is an agentic surface modeled with an agent-specific method (here, no). Maturity frames (SSDF/SAMM/BSIMM) measure the org's program, not this diff. (security-appsec.md.)",
1136+
"expectations": [
1137+
"Flags the change as outrunning the existing model (new trust boundary/principal/transition) -- a stale model is a finding, not covered",
1138+
"Names MAESTRO as the fitting method for an agentic system (not general STRIDE), and names LINDDUN(privacy)/PASTA/attack-trees for their cases",
1139+
"Frames the lens as coverage (does the diff outrun the model / is the agentic surface modeled), not threat-model ceremony",
1140+
"Does not treat naming a maturity frame (SSDF/SAMM/BSIMM) as covering this diff"
1141+
]
11311142
}
11321143
]
11331144
}

‎.claude/skills/deep-code-review/references/security-ai-agents.md‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,10 @@ per-owner and collide).
143143

144144
Attacker techniques against agent tool ecosystems are also catalogued in **MITRE
145145
ATLAS** (e.g. poisoned agent tools, sandbox/host escape) — useful for building
146-
the red-team test set below.
146+
the red-team test set below. To *model* an agentic system's threats systematically rather
147+
than only enumerate techniques, reach for **MAESTRO**, an agentic
148+
threat-modeling method — the method-side complement to these catalogs (`security-appsec.md`
149+
A06 names the general threat-model catalog: STRIDE / PASTA / attack trees / LINDDUN / MAESTRO).
147150

148151
---
149152

‎.claude/skills/deep-code-review/references/security-appsec.md‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,18 @@ rate limits, quotas, and business-logic limits **designed in** (e.g. can a user
272272
request 10,000 password resets, redeem a coupon twice, or race a balance check)?
273273
Secure defaults, or must the operator remember to turn safety on?
274274

275+
**Which threat-model method — name the one that fits, don't hand-wave "a threat model."**
276+
**STRIDE** (per element: Spoofing / Tampering / Repudiation / Info-disclosure / DoS /
277+
Elevation) for a component or data flow; **PASTA** when the model must tie threats to
278+
business impact; **attack trees** to decompose one attacker goal; **LINDDUN** for *privacy*
279+
threats (STRIDE's privacy counterpart); **MAESTRO** for an *agentic-AI* system — the agentic
280+
threat-modeling method, complementary to the OWASP ASI / MITRE ATLAS catalogs in
281+
`security-ai-agents.md`. The review lens is **coverage, not ceremony**: a change that
282+
introduces a new trust boundary, principal, or state transition the existing model never
283+
considered is a finding — the model went **stale relative to the diff** — and an agentic
284+
surface with no agent-specific (MAESTRO-shaped) model is the common miss. (Maturity frames —
285+
NIST SSDF, OWASP SAMM, BSIMM — measure the org's *program*, not this diff; name, don't score.)
286+
275287
**Detect steps, in order**
276288
- **Inventory the money/state machines.** List every flow that moves value or
277289
advances state: checkout, refund, credit/balance, coupon, invite, quota,

‎.claude/skills/idea-critic/VERSION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.103.0
1+
1.104.0

‎CHANGELOG.md‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,25 @@
33
All notable changes to this repository are documented here. Format loosely
44
follows Keep a Changelog; versioning follows Semantic Versioning.
55

6+
## [1.104.0] — 2026-09-17
7+
8+
Wave 25 of the dogfooding batch: #275, a threat-modeling method lens — the highest round-2
9+
gap after an idea-critic pass revised the sequence (ship #275 as a coverage lens now, the
10+
#267 precision/recall instrument next, #276 AI-governance deprioritized as the lowest
11+
review-action-density and the most date-sensitive).
12+
13+
### Added — deep-code-review
14+
- **`security-appsec.md` A06 + `security-ai-agents.md` — name the threat-modeling method,
15+
check coverage not ceremony** (#275). A06 already asks "is there a threat model?"; this
16+
names *which method fits* — STRIDE (per element), PASTA (business impact), attack trees (one
17+
attacker goal), **LINDDUN** (privacy, the `privacy-by-design.md` counterpart), **MAESTRO**
18+
(agentic AI, the modeling method behind the OWASP ASI / MITRE ATLAS catalogs in
19+
`security-ai-agents.md`) — and adds the coverage lens: a change that introduces a trust
20+
boundary, principal, or state transition the existing model never considered is a finding
21+
(the model went stale relative to the diff), and an agentic surface with no agent-specific
22+
model is the common miss. Maturity frames (NIST SSDF, OWASP SAMM, BSIMM) measure the org's
23+
program — named, not scored. One new eval (107 total).
24+
625
## [1.103.0] — 2026-09-17
726

827
Wave 24 of the dogfooding batch: two of the three HIGH gaps from the 2026-09-17

‎SHA256SUMS‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
1575e1af4a95f12f70b4ee6a6adce8160953d93ea17dc2611b90883ccc3ad3b8 .claude/skills/agentic-ceo/VERSION
33
3122784e8b188babadd7ceb0dddf69cfb308e7a02bbf67ed82cf3527a81f5eb1 .claude/skills/agentic-ceo/evals/evals.json
44
bf4e6bdfb953e0333beea9d6d98d23856d0f96870b88fbbe7cf039b10e2659c8 .claude/skills/agentic-delivery/SKILL.md
5-
e1aa83e832fbd3099bad45d0fe11cd8a7e98e797c2be106f006a021dac72d192 .claude/skills/agentic-delivery/VERSION
5+
a95496ede1430dd3466e1d5cdb3a2206e81b44c16311e6f04dcb0d690b20d585 .claude/skills/agentic-delivery/VERSION
66
ca9dc9e3179a296e03ab7e0d8bda9e109c88c00e4a27a83d2062244e309262f2 .claude/skills/agentic-delivery/evals/evals.json
77
863b7535b90efad3c661a8eb3a24fc6356c6fa54e8874c05bee11f110d30274b .claude/skills/agentic-delivery/references/fast-agentic-delivery.md
88
200e58588607d6c444811d91722cc327bbb6b9a5236dcd0c03d3d70936c61b30 .claude/skills/agentic-delivery/references/host-enforcement.md
@@ -26,8 +26,8 @@ b8a4c1ae0a34cf8c692d42bf4ad10a1ba21f85c0dd489cbfc2bdae275bb7412a .claude/skills
2626
3f047b5935d72317605691d0fc4e6357cf6c44d1b91347eb2fc36e75497f7382 .claude/skills/contribution/kernel-paths.txt
2727
bb541f96bd7d0c3bb4adff8dcaac0f50efa2493b8215b6aa671805bfbb89c42b .claude/skills/contribution/references/contribution-procedure.md
2828
e6a7ca15b7e2e33bfeb6e0ec7e659aeeaf1c40e6e6897af10f863e7b36b200a0 .claude/skills/deep-code-review/SKILL.md
29-
e1aa83e832fbd3099bad45d0fe11cd8a7e98e797c2be106f006a021dac72d192 .claude/skills/deep-code-review/VERSION
30-
f33d0bb33d610a5390af8dc3f6b8c7f2e5216166e9f9f143c137812ff2a906aa .claude/skills/deep-code-review/evals/evals.json
29+
a95496ede1430dd3466e1d5cdb3a2206e81b44c16311e6f04dcb0d690b20d585 .claude/skills/deep-code-review/VERSION
30+
4a4df4d51b156d123e13ad036c1633a0c01b62db813ed4ba45ea16185e0dbea2 .claude/skills/deep-code-review/evals/evals.json
3131
1c1f26b3d109a50fbf40863404dd0c0130ddcc639a5bcb7ff99780f9d5eb68e0 .claude/skills/deep-code-review/references/api-contracts.md
3232
93d695b99b448a59b1b7e4de3449692847089ba36e9530d0e24d19c04650efc1 .claude/skills/deep-code-review/references/billing-correctness.md
3333
b7f3f4783f74603a0bc9a8bdf7f869e201f417b2ff1d5c8c013016ed7f351887 .claude/skills/deep-code-review/references/branch-and-merge-hygiene.md
@@ -57,8 +57,8 @@ dd55bd244d2fda874f9ae65d84c287fa86582ee4e108b71714eb1f5de7451e22 .claude/skills
5757
98e7dd0b0def3ed687a90f86237d0a2c2195067fb47d6e8662d792abac6e7ecc .claude/skills/deep-code-review/references/report-format.md
5858
e4842666073f6dfe8f173758289c7015204c1a504d99b9b6f0b5aa32a0ab9f76 .claude/skills/deep-code-review/references/role-coverage.md
5959
4e3672bd86fe39b2e2c026072b0c8224b2ff4ca22f365bbbcb0bf1fc5f7c34b9 .claude/skills/deep-code-review/references/security-agent-skills.md
60-
7ac5ae3189853b9dfc92b36c4317d75c83bc7fdc5175fb9e977290daea14b725 .claude/skills/deep-code-review/references/security-ai-agents.md
61-
39cdf34d4a7f3ac34006f5e58dc441ea196efe1bb4d6d93e625d947cae8e53b0 .claude/skills/deep-code-review/references/security-appsec.md
60+
1e6025cdc644600931a1334f79b70da2e10922c0dc72d8a5c05cd79b8f77aadd .claude/skills/deep-code-review/references/security-ai-agents.md
61+
f846710289004e4a7d3b76c11bba3a43073fddde1949f2e1f866745e711fe1cd .claude/skills/deep-code-review/references/security-appsec.md
6262
db531493cde2dbb62efaab3890b8187ed39d30926c4ec956fa8319bee9f504af .claude/skills/deep-code-review/references/skill-authoring-and-size.md
6363
a0ed7ad061b7e60230601ee9b38a00400841d6ddf3af386edbd4b34a981c9798 .claude/skills/deep-code-review/references/standards-index.md
6464
c0cbd6c04eda341f96fd8aa855fa5decae926f39be34f614fdd456d4f1c0832c .claude/skills/deep-code-review/references/testing-and-evals.md
@@ -67,7 +67,7 @@ c0cbd6c04eda341f96fd8aa855fa5decae926f39be34f614fdd456d4f1c0832c .claude/skills
6767
59854984853104df5c353e2f681a15fc7924742f9a2e468c29af248dce45ce03 .claude/skills/growth-analytics/VERSION
6868
0d3682e5c4d52bcec5531ad444d774db27959bbfb4a0f70913b7238be8f700bc .claude/skills/growth-analytics/evals/evals.json
6969
e31da55ecf5f8e00702275d64055a495da0ade344ded674a9f088dc2b7526546 .claude/skills/idea-critic/SKILL.md
70-
e1aa83e832fbd3099bad45d0fe11cd8a7e98e797c2be106f006a021dac72d192 .claude/skills/idea-critic/VERSION
70+
a95496ede1430dd3466e1d5cdb3a2206e81b44c16311e6f04dcb0d690b20d585 .claude/skills/idea-critic/VERSION
7171
56834cda92b67888a549b6d714fbd4d3e097ff78da10e0cb2496a422e181f82a .claude/skills/idea-critic/evals/evals.json
7272
c5615e5c59bc2e452c2c49619be2ec5e456f3c167e772498316f8b5a45deb2c8 .claude/skills/idea-critic/references/decision-hygiene.md
7373
612a8b0426f4cad71f88aa5aead935351a6c586b74bf34d8ef39f2df2f9f72d1 .claude/skills/idea-critic/scripts/validate_verdict.py

0 commit comments

Comments
 (0)