Skip to content

Commit 3377a43

Browse files
remigiusz-antczakRemigiusz Antczakclaude
authored
feat(skill): 1.143.0 — wave 64 reversible-action-reads-as-delete UX lens (#351) (#387)
product-ux-quality.md (domain P): an action presented as non-destructive (resolve/archive/dismiss, backed by a retained resolved_at/archived_at) that removes the record while giving no cue it persists, is reversible, or where it went reads as a hard delete — a product-safety failure (suppresses a reversible action) and an audit/history-visibility failure (a reachable trail the UI never surfaces; data intact, visibility is the defect). Scoped to the hidden reversibility, not default-hiding as such: hiding a completed item behind a known filter (is:open, active board, inbox archive) is a convention; a soft-delete (deleted_at) is out of scope. Fail-open — a human adjudicates. Fix: keep the record in place muted + a status label, or a discoverable labelled resolved/archived view; not colour-alone; verify on the running default surface. One eval + one domain-P checklist box (deep-code-review 135 to 136 evals). Trio to 1.143.0. Dogfood reviewer: FIX-FIRST -> fixed pre-merge. High: the flag criterion was over-broad (flagged conventional archive/is:open hiding; prescribed rendering soft-deleted rows forever) -> rescoped, carved out conventions + soft-delete, added the fail-open clause; added the missing checklist box; relabelled data-integrity -> audit/history visibility. Tests: 19/19 gates green. Closes #351. Co-authored-by: Remigiusz Antczak <remigiusz@antczak.io> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent abba3d5 commit 3377a43

11 files changed

Lines changed: 78 additions & 15 deletions

File tree

‎.claude-plugin/plugin.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "deep-code-review",
33
"description": "Perun — bring the thunder to your codebase. A portable, evidence-grounded quality bar for building with AI agents: the flagship deep-code-review skill (default install is review-only), plus opt-in overlays — gated delivery, an idea critic, a suite conductor, and stage-aware product, growth, positioning, business-ops, and output-safety specialists.",
44
"skills": "./.claude/skills",
5-
"version": "1.142.0",
5+
"version": "1.143.0",
66
"author": {
77
"name": "deep-code-review contributors"
88
},

‎.claude/skills/agentic-delivery/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ description: >-
1010
license: MIT
1111
metadata:
1212
author: deep-code-review contributors
13-
version: "1.142.0"
13+
version: "1.143.0"
1414
---
1515

1616
# Agentic delivery
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.142.0
1+
1.143.0

‎.claude/skills/deep-code-review/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ description: >-
1111
license: MIT
1212
metadata:
1313
author: deep-code-review contributors
14-
version: "1.142.0"
14+
version: "1.143.0"
1515
---
1616

1717
# Deep Code Review
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.142.0
1+
1.143.0

‎.claude/skills/deep-code-review/evals/evals.json‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1448,6 +1448,17 @@
14481448
"Fail closed when no liveness signal -- exclude or flag unknown, never 'rank everything, filter later'",
14491449
"Distinguishes a covered-but-dead entity from an uncovered one (honest-empty)"
14501450
]
1451+
},
1452+
{
1453+
"id": "soft-resolve-whose-default-view-hides-the-record-reads-as-a-delete",
1454+
"prompt": "A dashboard's 'Resolve' button sets `resolved_at` (row retained) but the default list drops the item; resolved items surface only via a 'Show resolved' filter that defaults off, sits in an overflow menu, and there is no 'Resolved' state, undo, or count anywhere on the surface. The team says 'it's not deleted, the data is still there.' Finding?",
1455+
"expected_output": "Flag it. The defect is not default-hiding as such -- it is that an action LABELLED non-destructive ('Resolve') removes the record while giving NO cue it persists, is reversible, or where it went (no 'Resolved' state, no undo, and the only path is a buried default-off filter). So it reads as a hard delete: (1) product-safety -- a first-time user concludes they deleted it, suppressing a reversible action; (2) audit/history visibility -- the retained trail is effectively unreachable (data intact; the defect is visibility, not integrity). Fix: keep the record in place, visually muted + a status label ('Resolved'), OR give a clearly-labelled, DISCOVERABLE resolved/archived view; not colour-alone. Caveats: default-hiding behind a KNOWN filter (an is:open list, an active board, inbox archive) is a convention, not this; a soft-DELETE (deleted_at) is out of scope. Fail-open -- a heuristic can't tell hidden-reversibility from a deliberate convention, so a human adjudicates. 'The data is still there' misses the point: the surface gives the user no cue of that. (product-ux-quality.md.)",
1456+
"expectations": [
1457+
"Scopes the defect to an action LABELLED non-destructive that hides the record with NO cue it persists/reverses (not default-hiding as such)",
1458+
"Names both failures -- product-safety (reads as destructive) AND audit/history VISIBILITY (data intact, visibility is the defect)",
1459+
"Fix: in place muted + status label OR a discoverable labelled resolved/archived view; not colour-alone",
1460+
"Carves out conventions (is:open / archive) and soft-delete as out of scope, and is fail-open -- a human adjudicates"
1461+
]
14511462
}
14521463
]
14531464
}

‎.claude/skills/deep-code-review/references/product-ux-quality.md‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,43 @@ coverage, not only the remedy: a bare "Nothing here" over an unprobed source is
118118
false all-clear, not an honest empty. (`data-quality.md` §8 owns the same rule
119119
where the number is *scored* rather than *shown*.)
120120

121+
## A reversible action reads as a delete when nothing shows the record persists
122+
123+
When an action **presented as non-destructive** — resolve / archive / dismiss,
124+
backed by a retained column (`resolved_at`, `archived_at`) — removes the record
125+
from view while giving **no cue that it persists, is reversible, or where it went**,
126+
the user cannot tell it from a hard delete. Two failures:
127+
- **Product-safety.** The action *reads* as destructive: a first-time user clicks
128+
"Resolve," watches the row vanish with no "Resolved" state, no undo, and no
129+
reachable resolved view, and reasonably concludes they deleted it — suppressing a
130+
reversible, low-stakes action and eroding trust in it.
131+
- **Audit / history visibility.** When the retained trail is *meant to be
132+
reviewable*, a surface with no way to reach it makes that history effectively
133+
invisible — the data layer keeps a record the UI never surfaces. (The data is
134+
intact; the defect is visibility, not integrity.)
135+
136+
**The defect is the hidden reversibility, not default-hiding as such.** Hiding a
137+
completed item is often the *correct* convention — an `is:open` list, an active-only
138+
board, an inbox that archives out of view all hide a retained record on purpose,
139+
behind a well-known filter; those are conventions, not defects (matching a
140+
convention is an observation, not a licence to redesign — read-first opener above).
141+
A **soft-delete** (`deleted_at`) is out of scope: "reads as a delete" is its
142+
*intended* behaviour; its concern is recoverability / trash-visibility, not this.
143+
Like the actionability rule, this is **fail-open**: a heuristic cannot tell a
144+
hidden-reversible action from a deliberate convention, so a human adjudicates every
145+
hit — surface options, never silently restyle.
146+
147+
The self-evident fix — how mature issue-trackers and code-review tools render a
148+
resolved thread — keeps the record **in place, visually muted** (opacity or
149+
strikethrough) with a **status label** ("Resolved"), or offers a clearly labelled,
150+
discoverable "resolved / archived" view. Cross-checks: the affordance must **not
151+
rely on colour alone** (pair opacity with a label or icon + accessible name, per
152+
*Never colour alone* below); a "show resolved / archived" path must be
153+
**discoverable**, not a buried default-off filter with no cue; verify on the
154+
**running app's default surface**, not only a unit test. Distinct from the
155+
honest-empty rule above (a *retained* record hidden by a *reversible* action, not an
156+
empty state).
157+
121158
## Encoding hygiene — one visual channel per dimension
122159

123160
Never make **one channel carry two meanings**. The classic bug: colour encoding
@@ -563,6 +600,7 @@ often lost — the on-screen chart carries axes and a readout the serialiser dro
563600
- [ ] Consistent type scale / spacing / components / number format with sibling views (tabular figures in columns)?
564601
- [ ] One shared component per concept — reused/extended, not reimplemented per page; a fix landed in the shared component, not one caller; **searched the tree for a duplicate twin (a duplicated visible string/heading) a diff-scoped review would miss**?
565602
- [ ] Interaction loops close — read-back on every input (no write-only), WYSIWYG not raw markup, no dead controls — checked on the route that actually renders?
603+
- [ ] Any action **labelled non-destructive** (resolve / archive / dismiss) that removes the record still shows it **persists** — a persisted-state label, an undo, or a discoverable resolved/archived view — so it doesn't read as a hard delete? (Default-hiding behind a *known* filter is a convention, not this; soft-delete is out of scope; **fail-open** — a human adjudicates.)
566604
- [ ] Every **disabled action explains its cause and a recovery path** — the unmet prerequisite + a concrete next step, in **reachable** text (nearby or a focusable wrapper/popover, not a tooltip on the disabled element, which may get no hover/focus); an action permanently unavailable to the current role is hidden or replaced, not a dead end?
567605
- [ ] **No write control renders as a dead/disabled default during the SSR → hydration window** — a control gated on client-only state (auth/session) shows a loading affordance (skeleton/spinner) or is optimistically enabled with its click **replayed** after hydration (never a dropped no-op), not a bare disabled button; confirmed on a **pre-hydration** snapshot, and *could-not-check* (no pre-hydration capture) fails **open**, not a silent pass?
568606
- [ ] Drawers overlay (don't navigate away); collapse scope correct; no dead controls?

‎.claude/skills/idea-critic/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ description: >-
99
license: MIT
1010
metadata:
1111
author: deep-code-review contributors
12-
version: "1.142.0"
12+
version: "1.143.0"
1313
---
1414

1515
# Idea critic

‎.claude/skills/idea-critic/VERSION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.142.0
1+
1.143.0

‎CHANGELOG.md‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,20 @@
33
All notable changes to this repository are documented here. Format loosely
44
follows Keep a Changelog; versioning follows Semantic Versioning.
55

6+
## [1.143.0] — 2026-09-18
7+
8+
Wave 64 — a UX / audit-visibility honesty lens for `product-ux-quality.md` (domain P), from owner-filed **#351**. When an action **presented as non-destructive** (resolve / archive / dismiss, backed by a retained `resolved_at` / `archived_at` column) removes the record while giving **no cue that it persists, is reversible, or where it went**, the user cannot tell it from a hard delete — two failures:
9+
- **Product-safety:** the action reads as destructive (a first-time user watches the row vanish and concludes they deleted it), suppressing a reversible, low-stakes action.
10+
- **Audit / history visibility:** when the retained trail is meant to be reviewable, an unreachable surface makes it effectively invisible (the data is intact; the defect is visibility, not integrity).
11+
12+
**Scoped to the hidden reversibility, not default-hiding as such:** hiding a completed item behind a known filter (an `is:open` list, an active board, inbox archive) is a convention, not a defect; a soft-**delete** (`deleted_at`) is out of scope ("reads as a delete" is intended there). **Fail-open** — a human adjudicates every hit. Fix: keep the record in place, muted + a status label, or a discoverable labelled resolved/archived view; not colour-alone; verify on the running app's default surface. Pattern described generically (no vendor named).
13+
14+
One eval + one domain-P checklist box (deep-code-review 135 → 136 evals). Trio → 1.143.0.
15+
16+
Dogfood reviewer: FIX-FIRST → fixed pre-merge. High: the flag criterion was over-broad (it flagged conventional archive / `is:open` default-hiding and prescribed rendering soft-deleted rows forever) — rescoped to labelled-non-destructive + no-persistence-cue, carved out conventions + soft-delete, added the fail-open human-adjudicates clause. Also added the missing sweep-checklist box and relabelled "data-integrity"→"audit / history visibility."
17+
18+
Closes #351.
19+
620
## [1.142.0] — 2026-09-18
721

822
Wave 63 — two anti-fabrication data-honesty axes for `data-quality.md` (scoring & config discipline, §7), from owner-filed **#344** and **#355**.

0 commit comments

Comments
 (0)