Skip to content

Commit 47abeb3

Browse files
feat(skill): 1.111.0 — wave 32 harden the frontmatter gate (check #6) to fail closed (#303)
Enumeration check #6 now fails closed: a skill dir must carry both a SKILL.md and a VERSION, and the stamp is read as metadata.version anchored to the 2-space direct child of the frontmatter metadata: block (a description block-scalar, body, or nested sub-key version cannot satisfy it). Two new planted-RED self-tests (missing VERSION; nested decoy) plus a metadata-anchor regression test and the reworded pre-existing missing-stamp; 72 gate tests. Closes #303. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 0c17218 commit 47abeb3

11 files changed

Lines changed: 118 additions & 34 deletions

File tree

‎.claude-plugin/plugin.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "deep-code-review",
33
"description": "Perun — bring the thunder to your codebase. A portable, evidence-grounded quality bar for building with AI agents: the flagship deep-code-review skill (default install is review-only), plus opt-in overlays — gated delivery, an idea critic, a suite conductor, and stage-aware product, growth, positioning, business-ops, and output-safety specialists.",
44
"skills": "./.claude/skills",
5-
"version": "1.110.0",
5+
"version": "1.111.0",
66
"author": {
77
"name": "deep-code-review contributors"
88
},

‎.claude/skills/agentic-delivery/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ description: >-
1010
license: MIT
1111
metadata:
1212
author: deep-code-review contributors
13-
version: "1.110.0"
13+
version: "1.111.0"
1414
---
1515

1616
# Agentic delivery
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.110.0
1+
1.111.0

‎.claude/skills/deep-code-review/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ description: >-
1111
license: MIT
1212
metadata:
1313
author: deep-code-review contributors
14-
version: "1.110.0"
14+
version: "1.111.0"
1515
---
1616

1717
# Deep Code Review
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.110.0
1+
1.111.0

‎.claude/skills/idea-critic/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ description: >-
99
license: MIT
1010
metadata:
1111
author: deep-code-review contributors
12-
version: "1.110.0"
12+
version: "1.111.0"
1313
---
1414

1515
# Idea critic

‎.claude/skills/idea-critic/VERSION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.110.0
1+
1.111.0

‎CHANGELOG.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,22 @@
33
All notable changes to this repository are documented here. Format loosely
44
follows Keep a Changelog; versioning follows Semantic Versioning.
55

6+
## [1.111.0] — 2026-09-18
7+
8+
Wave 32 of the dogfooding batch: #303 — harden the Wave-30 frontmatter gate (enumeration check
9+
#6) to fail closed, closing the fail-open it shipped with.
10+
11+
### Changed
12+
- **`ci-gates.sh` enumeration check #6 now fails closed** (#303). A skill dir must carry **both**
13+
a SKILL.md and a VERSION — a SKILL.md with no VERSION (or the reverse) now fails and names the
14+
skill, where before it was silently skipped (a fail-open in a gate whose contract is
15+
fail-closed). The stamp is read as **metadata.version**, anchored to the frontmatter
16+
`metadata:` block, so a `version:` in a description block-scalar or the body can no longer
17+
satisfy it; and an absent stamp, an unparseable stamp, and a drifted stamp are now reported
18+
distinctly. Two new planted-RED self-tests (missing VERSION; a nested sub-key decoy that must
19+
not mask a drift) plus a metadata-anchor regression test; the pre-existing missing-stamp
20+
planted-RED reworded to metadata.version; 72 gate tests.
21+
622
## [1.110.0] — 2026-09-17
723

824
Wave 31 of the dogfooding batch: #271 behavioral-hotspot prioritization for domain H — a

‎SHA256SUMS‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
6adb2f5421b22cc97f70e42f52c29dee95ee2d56c932c589f8dc08657d8bbb57 .claude/skills/agentic-ceo/SKILL.md
22
1575e1af4a95f12f70b4ee6a6adce8160953d93ea17dc2611b90883ccc3ad3b8 .claude/skills/agentic-ceo/VERSION
33
3122784e8b188babadd7ceb0dddf69cfb308e7a02bbf67ed82cf3527a81f5eb1 .claude/skills/agentic-ceo/evals/evals.json
4-
a683399376eef8b0a4facbb4096462f1b2ec8452f87f1de4baa55df206c83d9c .claude/skills/agentic-delivery/SKILL.md
5-
02e1d84ba3e72b900a2f87ffdb91d811622ce09d59c5c6acf96688a3446b2aec .claude/skills/agentic-delivery/VERSION
4+
eb64714a92bd73a9d2858d5bc8d83b8377d45455ce880ee25ecefd0b184e110c .claude/skills/agentic-delivery/SKILL.md
5+
a79055df6ae277a11355ae159bb72735c83272c759914804fb056b8eb989b571 .claude/skills/agentic-delivery/VERSION
66
ca9dc9e3179a296e03ab7e0d8bda9e109c88c00e4a27a83d2062244e309262f2 .claude/skills/agentic-delivery/evals/evals.json
77
863b7535b90efad3c661a8eb3a24fc6356c6fa54e8874c05bee11f110d30274b .claude/skills/agentic-delivery/references/fast-agentic-delivery.md
88
200e58588607d6c444811d91722cc327bbb6b9a5236dcd0c03d3d70936c61b30 .claude/skills/agentic-delivery/references/host-enforcement.md
@@ -25,8 +25,8 @@ c2787ff299a66444b2e4b4f20e9af2e7843a5b0d02ebacf76c84d4c411db3683 .claude/skills
2525
b8a4c1ae0a34cf8c692d42bf4ad10a1ba21f85c0dd489cbfc2bdae275bb7412a .claude/skills/contribution/evals/evals.json
2626
3f047b5935d72317605691d0fc4e6357cf6c44d1b91347eb2fc36e75497f7382 .claude/skills/contribution/kernel-paths.txt
2727
bb541f96bd7d0c3bb4adff8dcaac0f50efa2493b8215b6aa671805bfbb89c42b .claude/skills/contribution/references/contribution-procedure.md
28-
6037f030df0e8ca01ebe3dae06ecafe017af03f32611f59a0c9a961dc0723e62 .claude/skills/deep-code-review/SKILL.md
29-
02e1d84ba3e72b900a2f87ffdb91d811622ce09d59c5c6acf96688a3446b2aec .claude/skills/deep-code-review/VERSION
28+
f87099c2685ac1ffdbb73da425f201f68d30f864a4d14d5a04f73084a1e7975c .claude/skills/deep-code-review/SKILL.md
29+
a79055df6ae277a11355ae159bb72735c83272c759914804fb056b8eb989b571 .claude/skills/deep-code-review/VERSION
3030
1eeabc485eac344b1f256d1fc2607f2ab1c4f19053399102e7f0d56bb04036ce .claude/skills/deep-code-review/evals/evals.json
3131
1c1f26b3d109a50fbf40863404dd0c0130ddcc639a5bcb7ff99780f9d5eb68e0 .claude/skills/deep-code-review/references/api-contracts.md
3232
93d695b99b448a59b1b7e4de3449692847089ba36e9530d0e24d19c04650efc1 .claude/skills/deep-code-review/references/billing-correctness.md
@@ -66,8 +66,8 @@ c0cbd6c04eda341f96fd8aa855fa5decae926f39be34f614fdd456d4f1c0832c .claude/skills
6666
622da72f7f784af9b73f46021099bb885d3088714c3f040dbec0085eadedb874 .claude/skills/growth-analytics/SKILL.md
6767
59854984853104df5c353e2f681a15fc7924742f9a2e468c29af248dce45ce03 .claude/skills/growth-analytics/VERSION
6868
0d3682e5c4d52bcec5531ad444d774db27959bbfb4a0f70913b7238be8f700bc .claude/skills/growth-analytics/evals/evals.json
69-
965a9fb019eea474f95c9b071320985cbfebd7f0ecac25ce508c7e29af2e2ec2 .claude/skills/idea-critic/SKILL.md
70-
02e1d84ba3e72b900a2f87ffdb91d811622ce09d59c5c6acf96688a3446b2aec .claude/skills/idea-critic/VERSION
69+
fcc91409ae0400f7c20bae167d5a1146ee0e2b2bc936b0a083546088626e572f .claude/skills/idea-critic/SKILL.md
70+
a79055df6ae277a11355ae159bb72735c83272c759914804fb056b8eb989b571 .claude/skills/idea-critic/VERSION
7171
56834cda92b67888a549b6d714fbd4d3e097ff78da10e0cb2496a422e181f82a .claude/skills/idea-critic/evals/evals.json
7272
c5615e5c59bc2e452c2c49619be2ec5e456f3c167e772498316f8b5a45deb2c8 .claude/skills/idea-critic/references/decision-hygiene.md
7373
612a8b0426f4cad71f88aa5aead935351a6c586b74bf34d8ef39f2df2f9f72d1 .claude/skills/idea-critic/scripts/validate_verdict.py

‎scripts/ci-gates.sh‎

Lines changed: 37 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ cmd_enumeration() {
388388
done
389389

390390
local bt='`'
391-
local fail=0 d name sver fmver
391+
local fail=0 d name sver fmver fmline has_skill has_ver
392392
for d in "$skills_dir"/*/; do
393393
[ -d "$d" ] || continue
394394
name="$(basename "$d")"
@@ -417,23 +417,43 @@ cmd_enumeration() {
417417
# not a substring of "idea-critic").
418418
grep -qF "\"${name}\"" "$recommend" \
419419
|| { printf 'ENUM: %s not named in recommend-overlays.py\n' "$name" >&2; fail=1; }
420-
# 6) SKILL.md frontmatter metadata.version must equal this skill's own VERSION.
421-
# Nothing reads this stamp at runtime, so a drift is invisible to every
422-
# other gate — it slid on the lockstep skills for seven releases
423-
# (v1.101.0–v1.107.0) before this check. Compared only when BOTH files
424-
# exist: per-skill VERSION presence is not itself gated today, so a skill
425-
# with a SKILL.md but no VERSION is skipped here, not failed (tracked as a
426-
# fail-closed follow-up). The frontmatter version is read strictly from
427-
# inside the leading `---` block, so a body `version:` cannot satisfy it.
428-
if [ -f "$d/VERSION" ] && [ -f "$d/SKILL.md" ]; then
420+
# 6) A skill dir must carry BOTH a SKILL.md and a VERSION, and the SKILL.md
421+
# frontmatter metadata.version must equal that VERSION. Fail closed: nothing
422+
# reads the stamp at runtime, so without this check a drift — or a missing
423+
# VERSION — is invisible to every other gate (the stamp slid on the lockstep
424+
# skills for seven releases, v1.101.0–v1.107.0, before it existed). The stamp
425+
# is read as metadata.version — the version: key inside the frontmatter
426+
# metadata: block — so neither a body line nor a description block-scalar
427+
# version: can satisfy it. A dir with NEITHER file is an empty dir, not a
428+
# malformed skill; checks 1–5 already fail an unenumerated dir.
429+
has_skill=0; has_ver=0
430+
if [ -f "$d/SKILL.md" ]; then has_skill=1; fi
431+
if [ -f "$d/VERSION" ]; then has_ver=1; fi
432+
if [ "$has_skill" = 1 ] && [ "$has_ver" = 0 ]; then
433+
printf 'ENUM: %s has a SKILL.md but no VERSION (fail closed)\n' "$name" >&2; fail=1
434+
elif [ "$has_ver" = 1 ] && [ "$has_skill" = 0 ]; then
435+
printf 'ENUM: %s has a VERSION but no SKILL.md (fail closed)\n' "$name" >&2; fail=1
436+
elif [ "$has_skill" = 1 ] && [ "$has_ver" = 1 ]; then
429437
sver="$(LC_ALL=C tr -d '\n' < "$d/VERSION")"
430-
# `|| true`: an empty frontmatter (no version line) yields no grep match,
431-
# whose exit 1 would abort under `set -o pipefail`; the empty result is the
432-
# signal the missing-stamp branch below acts on. Same idiom as cmd_version.
433-
fmver="$(awk '/^---[[:space:]]*$/{c++; next} c>=2{exit} c==1 && /^[[:space:]]*version:/{print; exit}' "$d/SKILL.md" \
434-
| grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1 || true)"
435-
if [ -z "$fmver" ]; then
436-
printf 'ENUM: %s SKILL.md has no frontmatter version stamp\n' "$name" >&2; fail=1
438+
# Extract metadata.version, anchored to the metadata: block. `|| true`: no
439+
# match yields grep exit 1, which would abort under `set -o pipefail`; the
440+
# empty result is the signal the absent/unparseable branches act on.
441+
# Match version: only as a DIRECT child of metadata: (the repo's 2-space
442+
# convention, verified across all skills). A deeper-nested `sub:\n version:`
443+
# is skipped, so a nested decoy cannot mask a drift of the real stamp; a skill
444+
# that deviates from 2-space reads as "no stamp" and fails closed.
445+
fmline="$(awk '
446+
/^---[[:space:]]*$/ {c++; next}
447+
c!=1 {next}
448+
/^metadata:[[:space:]]*$/ {inmeta=1; next}
449+
/^[^[:space:]]/ {inmeta=0}
450+
inmeta && /^ version:[[:space:]]/ {print; exit}
451+
' "$d/SKILL.md" || true)"
452+
fmver="$(printf '%s' "$fmline" | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1 || true)"
453+
if [ -z "$fmline" ]; then
454+
printf 'ENUM: %s SKILL.md has no metadata.version stamp\n' "$name" >&2; fail=1
455+
elif [ -z "$fmver" ]; then
456+
printf 'ENUM: %s SKILL.md metadata.version is unparseable (%s)\n' "$name" "$(printf '%s' "$fmline" | tr -s '[:space:]' ' ')" >&2; fail=1
437457
elif [ "$fmver" != "$sver" ]; then
438458
printf 'ENUM: %s SKILL.md frontmatter version (%s) != VERSION (%s)\n' "$name" "$fmver" "$sver" >&2; fail=1
439459
fi

0 commit comments

Comments
 (0)