Skip to content

Commit aa39f38

Browse files
Dependabot cooldown, shellcheck comment fix, fail-closed cd
Add a 7-day cooldown to the dependabot update entry, reword a comment in test-provision-tools.sh that shellcheck parsed as a directive, and make run-ci-tests.sh and test-host-manifests.sh exit when their initial cd fails. Tests: 164/166 (test-ci-gates.sh; 2 fails pre-existing in sandbox: size budget, dcr-gates opt-in; baseline had 8 fails) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1 parent 5b31539 commit aa39f38

5 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎.github/dependabot.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@ updates:
55
schedule:
66
interval: weekly
77
open-pull-requests-limit: 2
8+
cooldown:
9+
default-days: 7

‎changelog.d/dependabot-cooldown.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
### Fixed
2+
- dependabot.yml sets a 7-day cooldown so new releases are not proposed the day they ship (clears the dependabot-missing-cooldown finding). A comment in test-provision-tools.sh no longer parses as a shellcheck directive. run-ci-tests.sh and test-host-manifests.sh now exit when their initial cd fails, so they fail closed if path resolution fails.

‎scripts/run-ci-tests.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
# --list-affected [BASE]: the dry form of --affected: prints "affected: N of M tests" and one "selected: <suite>" line per suite it would run,
2222
# then exits 0 without the privacy/trigger gates, any suite or any receipt (lkg.py affected-check re-derives the selection with it).
2323
set -uo pipefail
24-
cd "$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
24+
cd "$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)" || exit 1
2525
affected=0 list=0 base="${RUN_CI_BASE:-}" arg=
2626
case "${1:-}" in
2727
--affected) affected=1; arg="${2:-}" ;;

‎scripts/test-host-manifests.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# release version, and point at paths that exist. Their stamping by land-release.sh is covered by the version gate.
44
set -uo pipefail
55
ROOT="$(cd "$(dirname "$0")/.." && pwd)"
6-
cd "$ROOT"
6+
cd "$ROOT" || exit 1
77
ver=$(cat .claude/skills/deep-code-review/VERSION)
88
python3 - "$ver" <<'PY'
99
import json, os, sys

‎scripts/test-provision-tools.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ e "review_checks: partial: semgrep ran but reported errors" && e "review_checks:
174174
rc_run SG_ERR='{"message":"boom"}' # errors and no findings: nothing usable was scanned
175175
e "not run: semgrep (scan errored, no findings)" && st '.not_run == ["semgrep"] and .partial == []' && ok "semgrep with errors and no findings: not run, not partial" || { bad "errored semgrep"; cat "$T/err"; }
176176

177-
# shellcheck, ruff and the history scan count as wired, but provision_tools.sh cannot install them: not run, never fixable
177+
# Tools: shellcheck, ruff and the history scan count as wired, but provision_tools.sh cannot install them: not run, never fixable
178178
mkrepo repo3; echo 'echo hi' >t.sh; echo 'x = 1' >t.py; commit
179179
SX=$(mktemp -d "$T/sx.XXXXXX"); printf '#!/bin/sh\nexit "${LINT_RC:-0}"\n' >"$SX/shellcheck"; printf '#!/bin/sh\ncase "$*" in *json*) echo "[]" ;; esac\nexit "${LINT_RC:-0}"\n' >"$SX/ruff" # ruff also backs the ruff-security hub row (JSON)
180180
printf '#!/bin/sh\necho %s\n' "'{\"results\":[]}'" >"$SX/bandit"; chmod +x "$SX"/* # bandit: the hub tool a .py file wires

0 commit comments

Comments
 (0)