You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit de41a5a
Browse filesBrowse the repository at this point in the historyBrowse files
Reproduce a finding against the build and SHA it came from, and validate the receipt.
Three dogfood lessons, each referencing existing canon (the reproduce-with-detector
family, principle 2, the pinned start_sha) rather than restating it.
method.md:
- Reproduce a built-artifact finding against the build it audits, not the dev server
(#206). The environment axis of reproduction fidelity: a production-build audit
finding (a control obscured under a sticky header, a WCAG focus-not-obscured
failure) often will not appear on the dev server -- minification, CSS order,
hydration, asset paths differ. A dev-server "can't reproduce" does not refute it.
- Re-validate a carried-forward finding before repeating it (#217). A finding at an
earlier start_sha is a hypothesis until re-checked: confirm the file:line exists at
HEAD and re-run the surfacing gate. Repeating an already-fixed finding is a false
positive; reporting a worsened one as unchanged over-claims a trust-critical status
(rate the claim). "Still open" holds only at the current SHA.
report-format.md:
- The report records its capture SHA (#217) -- a "Reviewed at (start_sha)"
ground-truth line, matching the machine report's field, so a follow-up knows what
to re-verify each finding against.
product-ux-quality.md:
- The UI receipt must be a valid non-empty image (#209) -- a proxy/504-wiped stub
passes a bare existence check but proves nothing (existence is not content,
principle 2); capture from a clean or separate tree (a shots script that stashes
discards the diff under review).
Two new evals (88 total). Lockstep bump to 1.91.0; SHA256SUMS regenerated.
Independent dogfood reviewer: PASS.
Closes#206, #209, #217.
Co-authored-by: Remigiusz Antczak <remigiusz@antczak.io>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: .claude-plugin/plugin.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -2,7 +2,7 @@
2
2
"name": "deep-code-review",
3
3
"description": "Perun — bring the thunder to your codebase. A portable, evidence-grounded quality bar for building with AI agents: the flagship deep-code-review skill (default install is review-only), plus opt-in overlays — gated delivery, an idea critic, a suite conductor, and stage-aware product, growth, positioning, business-ops, and output-safety specialists.",
"prompt": "A follow-up review session. The prior report (captured at SHA a1b2c3) lists a Blocker: a missing authz check at api/orders.ts:88. The branch has since advanced 20 commits. Can I carry that Blocker into the new report as still-open?",
915
+
"expected_output": "Not without re-validating it -- a finding carried forward from an earlier SHA without a re-run is a hypothesis, not a confirmed defect. The prior report resolves at its START_SHA (a1b2c3); the tree is now 20 commits ahead, so before repeating the Blocker: (1) re-check that api/orders.ts:88 still exists and still has the gap at HEAD (the line may have moved or the code may be gone), and (2) re-run the gate or probe that surfaced it. Carried forward unchecked it is unverified, not still-open. Two things go wrong if you skip this: the finding may already be FIXED in the 20 commits (repeating it is a false positive that spends the owner's trust), or it may have CHANGED or worsened while you report it unchanged -- reporting a worsened finding as still-open over-claims a trust-critical status; rate that claim, not the staleness. A 'still open' status is only valid at the current SHA -- so record the new report's START_SHA and re-verify each carried finding against it. (method.md.)",
916
+
"expectations": [
917
+
"Refuses to carry the finding forward as still-open without re-running it; a carried finding without a re-run is a hypothesis (unverified)",
918
+
"Requires re-checking the file:line exists at HEAD AND re-running the surfacing gate before repeating",
919
+
"Names both failure modes: repeating an already-fixed finding (false positive) and reporting a worsened one as unchanged (trust-critical over-claim)",
920
+
"Grounds validity at the current SHA and records the report's start_sha for the next re-verification"
"prompt": "A layout-audit gate that runs against our production build flags a focused control as fully obscured under the sticky header (WCAG focus-not-obscured), at several viewports. I ran the dev server and the control looks fully visible every time -- I can't reproduce it. Is the gate finding a false alarm I can dismiss?",
926
+
"expected_output": "No -- don't dismiss a production-build finding because the dev server can't reproduce it. The gate scored the PRODUCTION build (bundled, minified, deployed-style); the dev server is a different artifact -- minification, CSS ordering, hydration timing, and asset paths differ, so a sticky-header overlap real in the built output often does not appear in dev. This is repro fidelity at the ENVIRONMENT axis (the sibling of reproducing with the gate's own detector, and of the local-vs-CI divergence rule): reproduce against the same artifact the gate scored -- build the production bundle and inspect it, or hit the deployed/preview URL -- not the dev server. A dev-server 'looks fine' is unverified against the built surface, not a refutation. Chasing it on the dev server either fixes the wrong tree or dismisses a live accessibility defect. (method.md.)",
927
+
"expectations": [
928
+
"Refuses to dismiss the production-build finding on a dev-server non-repro; the dev server is a different artifact",
929
+
"Names why they diverge (minification, CSS order, hydration, asset paths) -- the environment axis of reproduction fidelity",
930
+
"Requires reproducing against the same artifact the gate scored (production build or deployed/preview URL)",
931
+
"Treats the dev-server 'looks fine' as unverified against the built surface, not a refutation"
Copy file name to clipboardExpand all lines: .claude/skills/deep-code-review/references/product-ux-quality.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -351,7 +351,7 @@ confidence number published as precision (confidence tier).
351
351
-[ ] Told "not the same" → **asked which axis** before acting (after one wrong guess, asked not guessed), and compared the **reference itself** at the element × breakpoint × theme, not from memory?
352
352
-[ ] Parity target expressed in **measured device-pixels at the actual render scale** (not user-space units — equal user-units ≠ equal pixels), and same-axis oscillation treated as a **duplicate-implementation-at-different-scale** signal (measure the ratio, don't tune)?
353
353
-[ ] No status is green-with-a-caveat — a status the author can immediately qualify is **downgraded**, not asserted beside a hedge (`report-format.md`)?
354
-
-[ ] UI change: headed-browser receipt on the exact route after the action (screenshot or equivalent)? Unit tests alone are not this box.
354
+
-[ ] UI change: headed-browser receipt on the exact route after the action (screenshot or equivalent) — and the receipt is a **valid non-empty image**, not a proxy/504-wiped stub that passes a bare existence check (existence is not content — `SKILL.md` principle 2), captured from a **clean or separate tree** (a shots script that stashes uncommitted changes discards the very diff under review)? Unit tests alone are not this box.
355
355
356
356
## Parity claims: the default state is the canonical surface
0 commit comments