You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e07b613
Browse filesBrowse the repository at this point in the historyBrowse files
authored
feat(skill): 1.101.0 — wave 22 pre-hydration dead-controls (#256) and the read-first ask-ledger (#257) (#263)
Two owner-filed content lenses, each added to an already-routed reference (no
SKILL.md edits — both are at the 24000-byte budget; no new files).
#256 — product-ux-quality.md: a write control gated on client-only state
(useAuth/useSession) is server-rendered `disabled` and enables only after
hydration. For the SSR -> hydration window it is in the LOADING data state, not
the permanent-disabled class that owes an explanation (#240): render it as
loading (skeleton/spinner), or optimistic-enabled only when the click is captured
and replayed so the handler is never a no-op (a dropped pre-hydration click is
the dead-control / no-op-handler trust defect). Adds an interaction-completeness
bullet, a pre-ship checklist item, a gate-1 `not-dead-before-hydration` detector,
the fourth gate-1 timing class, and — per the independent review — the real
pre-hydration capture primitive in testing-and-evals.md the detector cites
(server-HTML / JS-disabled / throttled snapshot), so the gate has a routed
positive control rather than a citation to an absent instrument. The static
`disabled={!session}` tell stays an `unverified` lead; missing capture is
could-not-check and fails open.
#257 — fast-agentic-delivery.md: extends the unattended-work-loop rule so the
durable backlog is also indexed by the owner's ask-set (one row per request: id,
ask, status, evidence, next action), updated at each milestone and READ to answer
"what's left" in one or two tool calls, never reconstructed from the transcript.
A row is done only on the canonical surface (merged-to-default SHA / live URL) —
project-state.md's receipt discipline, linked not restated. Distinct from the
review-side end-of-session claim audit (method.md, #244) and the feedback-coverage
map (roles.md).
Lockstep version bump (deep-code-review, agentic-delivery, idea-critic, plugin) to
1.101.0; two new evals (dcr 102, agentic-delivery 27); SHA256SUMS regenerated.
Tests: 67/67 CI gates pass; both evals.json valid; secrets + privacy scans clean;
install.sh syntax OK; independent dogfood review FIX-FIRST -> one Medium fixed.
Co-authored-by: Remigiusz Antczak <remigiusz@antczak.io>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: .claude-plugin/plugin.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -2,7 +2,7 @@
2
2
"name": "deep-code-review",
3
3
"description": "Perun — bring the thunder to your codebase. A portable, evidence-grounded quality bar for building with AI agents: the flagship deep-code-review skill (default install is review-only), plus opt-in overlays — gated delivery, an idea critic, a suite conductor, and stage-aware product, growth, positioning, business-ops, and output-safety specialists.",
"prompt": "In a 7-hour unattended run the owner has asked 'how much is left?' six times. Each time my agent re-reads about a thousand lines of transcript to rebuild the list, and a couple of items got re-done because their 'done' status was based on a branch existing. We already run an end-of-session reconciliation. What's missing?",
274
+
"expected_output": "The end-of-session reconciliation is a run-once, review-side audit -- it does not fix MID-session drift, which is your actual failure. The durable backlog the loop already keeps must ALSO be indexed by the owner's ask-set: one row per distinct request (id, ask, status, evidence, next action), updated at each milestone, not only at the end. 'What's remaining' is then answered by READING that ledger -- one or two tool calls -- never by an O(N) re-scan of the transcript that silently re-litigates settled items. And a row is done only when its evidence points at the CANONICAL surface (a merged-to-default SHA or a live URL), not a branch that merely contains the fix -- project-state.md's receipt discipline (a checkpoint is a recorded claim, not evidence). The fix is not another audit; it is making the ledger a live, ask-indexed, read-first artifact. (fast-agentic-delivery.md.)",
275
+
"expectations": [
276
+
"Names mid-session drift as distinct from the end-of-session / review-side reconciliation, which does not fix it",
277
+
"Requires the durable backlog to carry the ask-set (one row per owner request) updated at each milestone",
278
+
"Answers 'what's left' by reading the ledger in one or two tool calls, not by re-scanning the transcript",
279
+
"Marks a row done only on the canonical surface (merged-to-default SHA / live URL), not branch existence -- links project-state.md receipt discipline"
"prompt": "On our app's home and weekly pages, the Add comment / Submit update / Ask AI buttons render disabled for the first few seconds on a cold load, then go live once the page finishes loading. They read from a client-side useSession hook. A reviewer filed it as a 'disabled control needs an explanation' issue. Is that the right call, and how do we gate it?",
1080
+
"expected_output": "No -- this is a different class from the contextually-disabled control that owes an explanation. That control STAYS disabled; these WILL enable themselves once the client bundle hydrates and useSession resolves. During the SSR -> hydration window they are in the LOADING data state, so they must LOOK loading -- a skeleton or spinner affordance -- not a bare dead-looking disabled button. The fix is a loading affordance, or optimistic-enabled ONLY if the click is captured and replayed after hydration so the handler is never a no-op; an enabled button whose pre-hydration click is silently dropped is the dead-control / no-op-handler trust defect, not a fix. Gate it as an unverified LEAD, not a finding: the static disabled={!session} pattern with no loading sibling is confirmed only by a pre-hydration render (a snapshot before the client bundle runs); where the harness cannot capture one, report could-not-check and fail open, never a silent pass. (product-ux-quality.md.)",
1081
+
"expectations": [
1082
+
"Reclassifies as the LOADING data state during the SSR -> hydration window, not the permanent contextually-disabled class that owes an explanation",
1083
+
"Requires a loading affordance (skeleton/spinner) or optimistic-enabled with the click replayed after hydration; a dropped pre-hydration click is the no-op-handler defect",
1084
+
"Treats the static disabled={!session} pattern as an unverified lead confirmed only by a pre-hydration render; missing capture is could-not-check / fail-open, not a pass",
1085
+
"Does not conflate it with the permanent-disabled-needs-explanation rule"
Copy file name to clipboardExpand all lines: .claude/skills/deep-code-review/references/product-ux-quality.md
+29-1Lines changed: 29 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -328,6 +328,23 @@ until it renders:
328
328
an attainable alternative**, not left visibly dead — unless its discoverability is
329
329
explicitly wanted (`frontend-a11y.md` owns the disabled-control *contrast*
330
330
exemption; this owns the *recoverability*).
331
+
-**A control disabled only until client state resolves is *loading*, not disabled —
332
+
render it as loading, never dead.** A write control (add, submit, compose) gated on
333
+
client-only state — `useAuth` / `useSession`, a hydration flag — is server-rendered in
334
+
its `disabled` default, then enabled once the client bundle resolves. For the seconds of
335
+
that SSR → hydration window it looks like a permanent dead control (the *no-dead-controls*
336
+
class above), but it is really in the **loading** data state (the five-states rule) and
337
+
must *look* loading — a skeleton or spinner affordance — not a bare disabled button with no
338
+
reason. This is a distinct class from the *contextually-unavailable* case just above: that
339
+
control **stays** disabled and owes an explanation; this one **will** enable itself and owes
340
+
a loading affordance. Optimistic-enabled (render it enabled, act on the click) is allowed
341
+
**only** when the click is captured and replayed after hydration, so the handler is never a
342
+
no-op — an enabled control whose pre-hydration click is dropped is the *dead control / no-op
343
+
handler* trust defect above, not a fix. The static tell — `disabled={!session}` on a write
344
+
action with no loading sibling — is an **`unverified` lead, not a finding**: only a
345
+
**pre-hydration render** (a snapshot taken before the client bundle runs,
346
+
`testing-and-evals.md`) confirms it, so where the harness cannot capture one the gate reports
347
+
*could-not-check* and fails **open**.
331
348
-**Reviewable change history, and no silent AI edits.** Any surface where an
332
349
edit is itself a decision of record (a value, a target, an assignment, an
333
350
owner) needs a visible who/what/when history behind the current value, not a
@@ -476,6 +493,7 @@ often lost — the on-screen chart carries axes and a readout the serialiser dro
476
493
-[ ] One shared component per concept — reused/extended, not reimplemented per page; a fix landed in the shared component, not one caller; **searched the tree for a duplicate twin (a duplicated visible string/heading) a diff-scoped review would miss**?
477
494
-[ ] Interaction loops close — read-back on every input (no write-only), WYSIWYG not raw markup, no dead controls — checked on the route that actually renders?
478
495
-[ ] Every **disabled action explains its cause and a recovery path** — the unmet prerequisite + a concrete next step, in **reachable** text (nearby or a focusable wrapper/popover, not a tooltip on the disabled element, which may get no hover/focus); an action permanently unavailable to the current role is hidden or replaced, not a dead end?
496
+
-[ ]**No write control renders as a dead/disabled default during the SSR → hydration window** — a control gated on client-only state (auth/session) shows a loading affordance (skeleton/spinner) or is optimistically enabled with its click **replayed** after hydration (never a dropped no-op), not a bare disabled button; confirmed on a **pre-hydration** snapshot, and *could-not-check* (no pre-hydration capture) fails **open**, not a silent pass?
479
497
-[ ] Drawers overlay (don't navigate away); collapse scope correct; no dead controls?
480
498
-[ ] Verified live in the running product, in more than the happy-path state — **including the default state a user lands on** (signed-out / no-role / default route / local default), not only a mock or a hand-picked persona view?
481
499
-[ ] Any "matches / exact / parity" claim checked against the **default served state of the tree under review** as the canonical surface (not whichever tree happens to hold the port — name url · branch · sha, `report-format.md`) — and if it rests on a non-default surface, does it **name** that surface and say the default was not checked?
@@ -653,6 +671,11 @@ task:
653
671
-**disabled-looks-disabled** — a functionally disabled control is *visibly*
654
672
disabled (cursor / opacity / painted colour, not only the attribute; the
655
673
*no-dead-controls* interaction-completeness rule above, seen in the render);
674
+
-**not-dead-before-hydration** — a write control gated on client-only state shows a
675
+
loading affordance (or is optimistic-enabled with a **replayed** click), not a bare
676
+
disabled default, in the **pre-hydration** render; the static `disabled={!session}` tell
677
+
is an `unverified` lead until that snapshot confirms it (principle 2), so a harness that
678
+
cannot capture pre-hydration reports *could-not-check*, never a pass;
656
679
-**state named** — which data state the shot is of (empty / loading / error /
657
680
populated), so an absence reads honestly (gate 2's state coverage; the
658
681
empty≠all-clear rule above);
@@ -677,7 +700,12 @@ task:
677
700
shot cannot see them, so on a `FULL` review they are ruled across the **rendered
678
701
route sweep**'s matrix (above). **Gutters and optional-slot reservation read at
679
702
rest** (the latter in the absent-slot data variant) — check them on the per-change
680
-
shot too, and re-confirm in the sweep rather than defer to it.
703
+
shot too, and re-confirm in the sweep rather than defer to it. And
704
+
**not-dead-before-hydration reads only before the client bundle runs** — a fourth timing
705
+
class neither the at-rest shot nor the mid-scroll sweep can see, because both capture the
706
+
*post-hydration* render; it needs a snapshot taken inside the SSR → hydration window (a
707
+
pre-hydration or CPU-throttled capture, `testing-and-evals.md`), and where the harness
708
+
cannot take one the item is *could-not-check*, not clean.
681
709
682
710
A screenshot with an unstated inspection is an artifact read as the verification
0 commit comments